-
Notifications
You must be signed in to change notification settings - Fork 25.4k
New issue
Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docs-infra): use chunk optimizer for adev builds #56830
Conversation
Deployed adev-preview ford8e9bf2to:https://ng-dev-previews-fw--pr-angular-angular-56830-adev-prev-0oeinkeo.web.app Note:As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
955d71e
to
ed6e0e9
Compare
Fwiw, Could you check on your side the lighthouse scores with "mobile" selected? |
Fromhttps://pagespeed.web.dev,LCP decreased from 6.0 to 5.6 seconds. First time visit will trigger the cookie notification which significantly alters the numbers which is always the case with pagespeed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Could you please rebase the PR, thank you! |
The Angular build system recently introduced an opt-in chunk optimizer for application builds. This is now enabled for adev production builds. It reduces the initial chunk count from 14 to 1 JavaScript file. While the raw initial total file size does increase by 0.75% (7.3kB), the total estimated transfer size decreases by 8% (17.8kB). Not only does this reduce the amount of data that must be sent over the network but it also reduces the amount of HTTP requests that must be made by the browser. While the injected HTML module preloads mitigate request cascades, not needing to make the requests is even better.
ed6e0e9
to
d8e9bf2
Compare
This PR was merged into the repository by commit163f4d0. The changes were merged into the following branches: main, 18.2.x |
The Angular build system recently introduced an opt-in chunk optimizer for application builds. This is now enabled for adev production builds. It reduces the initial chunk count from 14 to 1 JavaScript file. While the raw initial total file size does increase by 0.75% (7.3kB), the total estimated transfer size decreases by 8% (17.8kB). Not only does this reduce the amount of data that must be sent over the network but it also reduces the amount of HTTP requests that must be made by the browser. While the injected HTML module preloads mitigate request cascades, not needing to make the requests is even better. PRClose#56830
The Angular build system recently introduced an opt-in chunk optimizer for application builds. This is now enabled for adev production builds. It reduces the initial chunk count from 14 to 1 JavaScript file. While the raw initial total file size does increase by 0.75% (7.3kB), the total estimated transfer size decreases by 8% (17.8kB). Not only does this reduce the amount of data that must be sent over the network but it also reduces the amount of HTTP requests that must be made by the browser. While the injected HTML module preloads mitigate request cascades, not needing to make the requests is even better. PRCloseangular#56830
This issue has been automatically locked due to inactivity. Read more about ourautomatic conversation locking policy. This action has been performed automatically by a bot. |
The Angular build system recently introduced an opt-in chunk optimizer for application builds. This is now enabled for adev production builds. It reduces the initial chunk count from 14 to 1 JavaScript file. While the raw initial total file size does increase by 0.75% (+7.3kB), the total estimated transfer size decreases by 8% (-17.8kB). Not only does this reduce the amount of data that must be sent over the network but it also reduces the amount of HTTP requests that must be made by the browser. While the injected HTML module preloads mitigate request cascades, not needing to make the requests is even better.