fix(sdk): resolve some React 19+ issues in our testing tools #30742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit:1df5f45 Fingerprint diff[
{
"op":"changed",
"source":{
"type":"file",
"filePath":"../../packages/expo-font/package.json",
"reasons":[
"expoConfigPlugins"
],
"hash":"c982e5637332d396704c8353aac0431b8db4138f"
}
},
{
"op":"changed",
"source":{
"type":"dir",
"filePath":"../../packages/expo-modules-core",
"reasons":[
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash":"8df1f4081d727ca64a6bab64f3d86bff89800f2c"
}
}
]Generated byPR labeler🤖 |
byCedric
requested review from
brentvatne,
EvanBacon,
Kudo,
alanjhughes,
behenate,
tsapeta,
lukmccall,
ide,
aleqsio,
wschurman,
Simekand
amandeepmittal
ascode owners
byCedric
commented
Jul 31, 2024
| // The renderer is deprecated, but there is no replacement for React Native yet. | ||
| // Setting this global property disables the deprecation warning, and changes RTR to legacy mode. | ||
| // See: https://discord.com/channels/514829729862516747/514832743654228009/1266527040480477274 | ||
| globalThis.IS_REACT_NATIVE_TEST_ENVIRONMENT = true; |
There was a problem hiding this comment.
We could also define this in theexpo-module-scriptspreset, if we don't want to ship this temporary workaround to users.
There was a problem hiding this comment.
Edit: I'll pull it out ofjest-expoand intoexpo-module-scripts,we need a user-facing solution eventually and this is just a temporary workaround.
Kudo
approved these changes
Jul 31, 2024
Simek
approved these changes
Jul 31, 2024
tsapeta
approved these changes
Aug 1, 2024
byCedric
changed the title
byCedric
force-pushed
the
@bycedric/sdk/fix-react-testing-tools
branch
4 times, most recently
from
43f0c75
to
d20b33d
Compare
expo-bot
added
bot: passed checks
…with react-native
…ry with react-native
…rary with react-native
…ry in favor of `react-native`
Co-authored-by: Expo Bot <[email protected]>
…h `@testing-library/react-native`
byCedric
force-pushed
the
@bycedric/sdk/fix-react-testing-tools
branch
from
3ee29c4
to
969e7da
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
expo-bot
added
bot: suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There are a couple:
1. React 19 deprecates
react-test-rendererJust the deprecation warning alone causes a few tests to fail. Unfortunately, there is no replacement yet for React Native, meaning even if we did switch to
@testing-library/react-native,we'd still usereact-test-renderer.2.
@testing-library/react-hooksseems to be silently deprecated.There are no updates for React 18, or 19. For React 18, they mention to swap to
@testing-library/reactitself, and use therenderHookfunction the original library. That's why I pulled out@testing-library/react-hooksfrom our dependencies.3. Due to RTR being deprecated, we need to move over to
@testing-library/react-native.Unfortunately, we'd have to wait for proper React 19 support inhttps://github.com/callstack/react-native-testing-library.Right now, it seems that
react-test-rendererreturnsnullfor a lot of renders, which also seems to indicate there are issues in the current canary version we are using.How
Unfortunately, this won't fix the current test failures fully. But it does get us on a better path towards being green again (with
react-test-renderer@19)Test Plan
See CI
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).