[config-plugins] improve invalid config error message #31936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite.Learn more about stacking. |
|
Subscribed to pull request
Generated byCodeMention |
|
The Pull Request introduced fingerprint changes against the base commit:12a79eb Fingerprint diff[
{
"op":"changed",
"source":{
"type":"file",
"filePath":"../../packages/@expo/config-plugins/build/plugins/withPlugins.js",
"reasons":[
"expoConfigPlugins"
],
"hash":"2dcdd47f0b22b399c631a92e68e304c50549a29c"
}
},
{
"op":"changed",
"source":{
"type":"file",
"filePath":"../../packages/@expo/config-plugins/build/plugins/withStaticPlugin.js",
"reasons":[
"expoConfigPlugins"
],
"hash":"afe3b37f7a7149009f7bb2237083902a8f71f2f9"
}
}
]Generated byPR labeler🤖 |
vonovak
force-pushed
the
@vonovak/_config-plugins_improve_invalid_config_error_message
branch
from
577ebb6
to
5d3b717
Compare
expo-bot
added
bot: passed checks
vonovak
force-pushed
the
@vonovak/_config-plugins_improve_invalid_config_error_message
branch
3 times, most recently
from
326e4b4
to
2bfd773
Compare
byCedric
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
I don't have a strong opinion on having multi-linePluginErrormessage, let's see how that works in practice.
The error message itself:
- Avoid using "please" in errors, mostly to sound more confident
- Simplified the multi-line error's first line to closely match the normal
PluginErrormessage for non-objects - I'm not sure if "consult" is the easiest for non-native English speakers (I asked claude), used "See" instead.
Claude's take onconsult
packages/@expo/config-plugins/src/plugins/__tests__/withStaticPlugin-test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Cedric van Putten <[email protected]>
vonovak
force-pushed
the
@vonovak/_config-plugins_improve_invalid_config_error_message
branch
from
b1db2da
to
3faadee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
closes#31601
the snapshot update (2nd commit) is unrelated to other changes
How
makes the error message more helpful
Test Plan
tests pass
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).