[expo-go][ios][3/n] Convert BuildConstants and Versions to swift #32091
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stackon Graphite.
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@wschurmanand the rest of your teammates on |
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
| private(set) var isDevKernel: Bool = false | ||
| private(set) var defaultApiKeys: [String: Any] = [:] | ||
| private(set) var kernelDevManifestSource: KernelDevManifestSource =.none | ||
| private(set) var kernelManifestAndAssetRequestHeadersJsonString: String = "" |
There was a problem hiding this comment.
🟠 SwiftLint:Identifier Name Violation
Variable name 'kernelManifestAndAssetRequestHeadersJsonString' should be between 1 and 35 characters long
|
|
||
| let plistPath = Bundle.main.path(forResource: "EXBuildConstants", ofType: "plist" ) | ||
| let config = plistPath.let { it in | ||
| NSDictionary(contentsOfFile: it) |
There was a problem hiding this comment.
🟠 SwiftLint:Legacy Objective-C Reference Type Violation
Prefer Swift value types to bridged Objective-C reference types
| let plistPath = Bundle.main.path(forResource: "EXBuildConstants", ofType: "plist" ) | ||
| let config = plistPath.let { it in | ||
| NSDictionary(contentsOfFile: it) | ||
| }?? NSDictionary() |
There was a problem hiding this comment.
🟠 SwiftLint:Legacy Objective-C Reference Type Violation
Prefer Swift value types to bridged Objective-C reference types
| // local kernel. use manifest and assetRequestHeaders from local server. | ||
| kernelManifestAndAssetRequestHeadersJsonString = | ||
| config[ "BUILD_MACHINE_KERNEL_MANIFEST" ] as? String?? "" | ||
| break |
There was a problem hiding this comment.
🟠 SwiftLint:Unneeded Break in Switch Violation
Avoid using unneeded break statements
| // dev published kernel. use published manifest and assetRequestHeaders. | ||
| kernelManifestAndAssetRequestHeadersJsonString = | ||
| config[ "DEV_PUBLISHED_KERNEL_MANIFEST" ] as? String?? "" | ||
| break |
There was a problem hiding this comment.
🟠 SwiftLint:Unneeded Break in Switch Violation
Avoid using unneeded break statements
|
|
||
| private static func kernelManifestSource(from sourceString: String?) | ||
| -> KernelDevManifestSource | ||
| { |
There was a problem hiding this comment.
🟠 SwiftLint:Opening Brace Spacing Violation
Opening braces should be preceded by a single space and on the same line as the declaration
Why
How
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).