Removeconfig.capture_exception_frame_locals
#2306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
changed the title
config.capture_exception_frame_locals
CodecovReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 6.0-dev #2306 +/- ##
==========================================
Coverage? 98.66%
==========================================
Files? 201
Lines? 13075
Branches? 0
==========================================
Hits? 12901
Misses? 174
Partials? 0
|
It's been marked as deprecated for a while now and should be removed in the next major release.
st0012
force-pushed
the
drop-capture-exception-frame-locals-config
branch
from
693955c
to
9cf553d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been marked as deprecated for a while now and should be removed in the next major release.
Additional note: some TracePoint events can invalidate YJIT's optimization, which was a main concern of the current implementation around locals capturing. But at least until Ruby 3.3, the
raiseevent we're using is NOT one of them.