Skip to content
New issue

Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: security configuration needs to be per cluster, not from the top level cluster #6787

Open
zasweqopened this issue Nov 13, 2023 · 2 comments
Assignees
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P2 Type: Bug

Comments

@zasweq
Copy link
Contributor

zasweq commented Nov 13, 2023

Right now,https://github.com/grpc/grpc-go/blob/master/xds/internal/balancer/cdsbalancer/cdsbalancer.go#L155security configuration for the xDS tree is determined by the top level cluster in the cluster tree in the cds_balancer. This security configuration needs to be per cluster_impl (per priority). The initial idea is to persist a map from cluster name to security configuration in cds_balancer, set a resolver attribute in cluster_impl, and use that name from the attribute to read from the map here:https://github.com/grpc/grpc-go/blob/master/xds/internal/balancer/cdsbalancer/cdsbalancer.go#L674,rather than reading the entire handshake info directly.

@easwars
Copy link
Contributor

easwars commented Dec 13, 2023

Blocked ongrpc/proposal#404

@zasweq zasweq added the P2 label Dec 20, 2023
@arvindbr8
Copy link
Member

grpc/proposal#404is merged. This is unblocked now.

@purnesh42H purnesh42H added the Area: xDS Includes everything xDS related, including LB policies used with xDS. label Sep 8, 2024
@easwars easwars changed the title Security configuration needs to be per cluster, not from the top level cluster xds: security configuration needs to be per cluster, not from the top level cluster Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P2 Type: Bug
Projects
None yet
4 participants