Skip to content
New issue

Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 709: Comprehension iteration variable leaks into outer locals() #104619

Closed
JelleZijlstraopened this issue May 18, 2023 · 0 comments · Fixed by#104637
Closed

PEP 709: Comprehension iteration variable leaks into outer locals() #104619

JelleZijlstraopened this issue May 18, 2023 · 0 comments · Fixed by#104637
Assignees
@carljm
Labels
type-bug An unexpected behavior, bug, or error

Comments

@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 18, 2023 •
edited by bedevere-bot
Loading

Code:

def__b():
[__afor__bin[__b]for_in[]]
returnlocals()

On#104603,calling this gives:

>>> __b()
{'__b': <function __b at 0x100e3e390>}

But on 3.11:

>>> __b()
{}

So the locals() in the outer function can now include comprehension variables from the inner comprehension. cc@carljm

Linked PRs
@JelleZijlstra JelleZijlstra added the type-bug An unexpected behavior, bug, or error label May 18, 2023
@JelleZijlstra JelleZijlstra changed the title PEP 709: PEP 709: Comprehension iteration variable leaks into outer locals() May 18, 2023
@JelleZijlstra JelleZijlstra mentioned this issue May 18, 2023
Closed
@carljm carljm self-assigned this May 18, 2023
carljm added a commit to carljm/cpython that referenced this issue May 19, 2023
@carljm
pythongh-104619:never leak comprehension locals to outer locals()
58b7d96
@bedevere-bot bedevere-bot mentioned this issue May 19, 2023
Merged
@carljm carljm linked a pull request May 19, 2023 that will close this issue
gh-104619: never leak comprehension locals to outer locals() #104637
Merged
JelleZijlstra pushed a commit that referenced this issue May 19, 2023
@carljm
gh-104619:never leak comprehension locals to outer locals() (#104637)
70c7796
carljm added a commit to gsallam/cpython_with_perfmap_apii that referenced this issue May 20, 2023
@carljm
Merge branch 'main' into gsallam/main
ea5965a 
* main: (30 commits)
pythongh-103987:fix several crashes in mmap module (python#103990)
docs: fix wrong indentation causing rendering error in dis page (python#104661)
pythongh-94906:Support multiple steps in math.nextafter (python#103881)
pythongh-104472:Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (python#104667)
pythongh-103839:Allow building Tkinter against Tcl 8.7 without external libtommath (pythonGH-103842)
pythongh-85984:New additions and improvements to the tty library. (python#101832)
pythongh-104659:Consolidate python examples in enum documentation (python#104665)
pythongh-92248:Deprecate `type`, `choices`, `metavar` parameters of `argparse.BooleanOptionalAction` (python#103678)
pythongh-104645:fix error handling in marshal tests (python#104646)
pythongh-104600:Make type.__type_params__ writable (python#104634)
pythongh-104602:Add additional test for listcomp with lambda (python#104639)
pythongh-104640:Disallow walrus in comprehension within type scopes (python#104641)
pythongh-103921:Rename "type" header in argparse docs (python#104654)
Improve readability of `typing._ProtocolMeta.__instancecheck__` (python#104649)
pythongh-96522:Fix deadlock in pty.spawn (python#96639)
pythonGH-102818:Do not call `PyTraceBack_Here` in sys.settrace trampoline. (pythonGH-104579)
pythonGH-103545:Add macOS specific constants for ``os.setpriority`` to ``os`` (python#104606)
pythongh-104623:Update macOS installer to SQLite 3.42.0 (pythonGH-104624)
pythongh-104619:never leak comprehension locals to outer locals() (python#104637)
pythongh-104602:ensure all cellvars are known up front (python#104603)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carljm carljm

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-104619: never leak comprehension locals to outer locals() carljm/cpython
2 participants
@carljm @JelleZijlstra