Skip to content
New issue

Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101693: In sqlite3, deprecate using named placeholders with parameters supplied as a sequence #101698

Merged
merged 16 commits into from
Feb 15, 2023
Merged

gh-101693: In sqlite3, deprecate using named placeholders with parameters supplied as a sequence #101698

Changes from1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b693895
gh-101698: Deprecate using named placeholders with sequences
erlend-aaslandFeb 8, 2023
483e4d6
Update docs
erlend-aaslandFeb 8, 2023
e826428
Document deprecation in reference
erlend-aaslandFeb 8, 2023
132a6ee
Also test executemany
erlend-aaslandFeb 8, 2023
31cc188
Revert "Also test executemany"
erlend-aaslandFeb 8, 2023
660a742
Sync with main
erlend-aaslandFeb 9, 2023
a18d0bb
Address review: add test for query with more than one named param
erlend-aaslandFeb 9, 2023
3f94201
Address review: add PyErr_WarnFormat error handling
erlend-aaslandFeb 9, 2023
997ccc6
Sync with main
erlend-aaslandFeb 10, 2023
cb091af
Pull in main
erlend-aaslandFeb 14, 2023
450cdcc
Fixup
erlend-aaslandFeb 14, 2023
841e8a4
Apply Serhiy's suggestion
erlend-aaslandFeb 14, 2023
3e7b680
Pull in main
erlend-aaslandFeb 14, 2023
38d1110
Address Alex's review
erlend-aaslandFeb 14, 2023
cf3cfc8
Also amend NEWS and What's New
erlend-aaslandFeb 14, 2023
1687b65
Use deprecated-removed
erlend-aaslandFeb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docs
  • Loading branch information
@erlend-aasland
erlend-aasland committed Feb 8, 2023
commit483e4d6b26ee8e103f1d0fffb58bbd8cc1aafc60
8 changes: 7 additions & 1 deletion Doc/library/sqlite3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1950,7 +1950,7 @@ question marks (qmark style) or named placeholders (named style).
For the qmark style, *parameters* must be a
:term:`sequence` whose length must match the number of placeholders,
or a:exc:`ProgrammingError` is raised.
For the named style, *parameters*shouldbe
For the named style, *parameters*mustbe
an instance of a:class:`dict` (or a subclass),
which must contain keys for all named parameters;
any extra items are ignored.
Expand Down Expand Up @@ -1980,6 +1980,12 @@ Here's an example of both styles:

[('C', 1972)]

.. deprecated-removed:: 3.12 3.14

If named placeholders are used and *parameters* is a sequence,
:exc:`DeprecationWarning` is raised.
Starting with Python 3.14,:exc:`ProgrammingError` will be raised.

erlend-aaslandmarked this conversation as resolved.
Show resolved Hide resolved
.. note::

:pep:`249` numeric placeholders are *not* supported.
Expand Down