Skip to content
New issue

Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40465: Deprecate the optional argument to random.shuffle(). #19867

Merged
merged 5 commits into from
May 2, 2020

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented May 2, 2020

Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi, I think there is a typo in the warning message.

Lib/random.py Outdated Show resolved Hide resolved
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add an entry in What's New.

Comment on lines 211 to 212
.. deprecated:: 3.9
In the future, the optional argument *random* will be removed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks like theshuffle()function is deprecated. It should be specified that the argument is deprecated.

You can also use thedeprecated-removeddirective to specify the version of removing.

Lib/random.py Outdated Show resolved Hide resolved
@rhettinger rhettinger merged commit190fac9 into python:master May 2, 2020
@bedevere-bot
Copy link

@rhettinger:Please replace#withGH-in the commit message next time. Thanks!

This pull request wasclosed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants