Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth error when trying to create #735

Closed
jongio opened this issue Dec 5, 2018 · 4 comments
Closed

Auth error when trying to create #735

jongio opened this issue Dec 5, 2018 · 4 comments
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@jongio
Copy link

jongio commented Dec 5, 2018 •
edited
Loading

Version: 1.30.0-insider (user setup)
Commit: 85f805acf9436381b878cab5ab6c5146beec7893
Date: 2018-12-05T06:19:36.555Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Windows_NT x64 10.0.17134

Steps to Reproduce:

  1. Fork and clone
  2. Make change
  3. Add/commit/push
  4. Click Create PR + icon
  5. Select remote and branch
  6. Get error

Output:

[Info] GitHubRepository> Creating pull requests failed: {"message":"Validation Failed","errors":[{"resource":"PullRequest","field":"head","code":"invalid"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}
@jongio
Copy link
Author

jongio commented Dec 5, 2018

I tried again on a diff branch and got further, but it appears to have hung here:
image

I was able to create a PR with the extension to my fork...but not to the upstream. Both are private repos.

@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Dec 5, 2018
@RMacfarlane RMacfarlane mentioned this issue Dec 7, 2018
Merged
@jongio
Copy link
Author

jongio commented Dec 11, 2018

Thoughts on this? Would love to start using this feature 😃

RMacfarlane pushed a commit that referenced this issue Dec 11, 2018
Ensure correct head parameter when creating pull requests, fixes #735 (…
4db1ec0 
…#743)
@RMacfarlane
Copy link
Contributor

Just checked in a fix for it, I think we will try to release a new version of the extension soon

@jongio
Copy link
Author

jongio commented Dec 12, 2018

Great. Thanks @RMacfarlane !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jongio @RMacfarlane