fix: fix jobs test fail #773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasuaki640
had a problem deploying
to
external
GitHub Actions
Failure
yasuaki640
had a problem deploying
to
external
GitHub Actions
Failure
yasuaki640
had a problem deploying
to
external
GitHub Actions
Failure
yasuaki640
commented
Sep 15, 2024
| $keyOffset = 3; | ||
| $keyOffset = 2; |
There was a problem hiding this comment.
This fix is due to a change in php-http/multipart-stream-builder.
In v1.3.1, body has a Content-Length header (as shown below).
--66e64e8fe1f375.28637093
Content-Disposition: form-data; name="users”
Content-Length: 167
[{“email”: “[email protected]”, “email_verified”:true, “app_metadata”:{“roles”:[“admin”, “super”], “plan”: “premium “}, “user_metadata”:{“theme”: “dark”}}]
--66e64e8fe1f375.28637093
Content-Disposition: form-data; name="connection_id”
Content-Length: 16
__test_conn_id__
--66e64e8fe1f375.28637093
Content-Disposition: form-data; name="upsert”
Content-Length: 4
Content-Disposition: form-data; name=“upsert” Content-Length: 4
...
However, after v.1.3.1, the Content-Length header has been removed, so $keyOffset is misaligned and the test fails.
Therefore, I think it is better to fix the test with this fix to follow the changes in multipart-stream-builder.
There was a problem hiding this comment.
(And I think it is better to manage lock files by git as well.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixed pest failure.
The investigation of the change is described in the comment of the diff.
References
https://github.com/php-http/multipart-stream-builder/blob/1.x/CHANGELOG.md#140---2024-09-01
Testing
Contributor Checklist