Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DNS provider for Volcano Engine #2282

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Add DNS provider for Volcano Engine #2282

merged 6 commits into from
Oct 7, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 20, 2024 •
edited
Loading

  • be able to do: (and put the output of this command to a comment) 
    make build
rm -rf .lego

VOLC_ACCESSKEY=xxx \
VOLC_SECRETKEY=yyy \
./dist/lego --email [email protected] --dns volcengine -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    Note the wildcard domain is important.

Ping @liuruibin, can you run the command (with your domain, email, credentials, etc.)?

-> #2282 (comment)

Closes #2279

@ldez ldez mentioned this pull request Sep 20, 2024
Closed
5 tasks
@liuruibin

This comment was marked as outdated.

Sign in to view
@ldez
Copy link
Member Author

ldez commented Oct 5, 2024 •
edited
Loading

The min TTL depends on the account types: https://www.volcengine.com/docs/6758/170354

Property/Function Version Free Version Professional Edition Enterprise Edition Ultimate Premium Edition
TTL 600 seconds to 86400 seconds 300 seconds to 86400 seconds 60 seconds to 86400 seconds 1 second to 86400 seconds 1 second to 86400 seconds

So I will use the 600 by default.

@ldez

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@liuruibin

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@liuruibin

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@liuruibin

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@liuruibin

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@liuruibin

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@liuruibin
Copy link
Contributor 

VOLC_PROPAGATION_TIMEOUT=600 \
VOLC_POLLING_INTERVAL=60 \
VOLC_ACCESSKEY=xx \
VOLC_SECRETKEY=xx \
./dist/lego --email [email protected] --dns volcengine -d '*.wata.site' -d wata.site -s https://acme-staging-v02.api.letsencrypt.org/directory run

2024/10/06 11:20:26 No key found for account [email protected]. Generating a P256 key.
2024/10/06 11:20:26 Saved key to /Users/liuruibin/git_workspace/1panel/lego/.lego/accounts/acme-staging-v02.api.letsencrypt.org/[email protected]/keys/[email protected]
2024/10/06 11:20:26 Please review the TOS at https://letsencrypt.org/documents/LE-SA-v1.4-April-3-2024.pdf
Do you accept the TOS? Y/n
Y
2024/10/06 11:20:29 [INFO] acme: Registering account for [email protected]
!!!! HEADS UP !!!!

Your account credentials have been saved in your Let's Encrypt
configuration directory at "/Users/liuruibin/git_workspace/1panel/lego/.lego/accounts".

You should make a secure backup of this folder now. This
configuration directory will also contain certificates and
private keys obtained from Let's Encrypt so making regular
backups of this folder is ideal.
2024/10/06 11:20:29 [INFO] [*.wata.site, wata.site] acme: Obtaining bundled SAN certificate
2024/10/06 11:20:30 [INFO] [*.wata.site] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/14296675413
2024/10/06 11:20:30 [INFO] [wata.site] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/14296675423
2024/10/06 11:20:30 [INFO] [*.wata.site] acme: use dns-01 solver
2024/10/06 11:20:30 [INFO] [wata.site] acme: Could not find solver for: tls-alpn-01
2024/10/06 11:20:30 [INFO] [wata.site] acme: Could not find solver for: http-01
2024/10/06 11:20:30 [INFO] [wata.site] acme: use dns-01 solver
2024/10/06 11:20:30 [INFO] [*.wata.site] acme: Preparing to solve DNS-01
2024/10/06 11:20:31 [INFO] [wata.site] acme: Preparing to solve DNS-01
2024/10/06 11:20:31 [INFO] [*.wata.site] acme: Trying to solve DNS-01
2024/10/06 11:20:31 [INFO] [*.wata.site] acme: Checking DNS record propagation. [nameservers=[fe80::a6a9:30ff:fecc:74b4%en0]:53,192.168.31.1:53]
2024/10/06 11:21:31 [INFO] Wait for propagation [timeout: 10m0s, interval: 1m0s]
2024/10/06 11:21:36 [INFO] [*.wata.site] The server validated our request
2024/10/06 11:21:36 [INFO] [wata.site] acme: Trying to solve DNS-01
2024/10/06 11:21:36 [INFO] [wata.site] acme: Checking DNS record propagation. [nameservers=[fe80::a6a9:30ff:fecc:74b4%en0]:53,192.168.31.1:53]
2024/10/06 11:22:36 [INFO] Wait for propagation [timeout: 10m0s, interval: 1m0s]
2024/10/06 11:22:43 [INFO] [wata.site] The server validated our request
2024/10/06 11:22:43 [INFO] [*.wata.site] acme: Cleaning DNS-01 challenge
2024/10/06 11:22:43 [INFO] [wata.site] acme: Cleaning DNS-01 challenge
2024/10/06 11:22:44 [INFO] [*.wata.site, wata.site] acme: Validations succeeded; requesting certificates
2024/10/06 11:22:44 [INFO] Wait for certificate [timeout: 30s, interval: 500ms]
2024/10/06 11:22:45 [INFO] [*.wata.site] Server responded with a certificate.

@ldez
Copy link
Member Author

ldez commented Oct 6, 2024

Perfect, it works now 🎉

I will increase the default timeout to avoid using VOLC_PROPAGATION_TIMEOUT and VOLC_POLLING_INTERVAL.

@ldez ldez removed the state/need-user-tests Need users to test functionality label Oct 6, 2024
@ldez ldez marked this pull request as ready for review October 6, 2024 03:27
@ldez ldez added this to the v4.20 milestone Oct 6, 2024
@ldez ldez requested a review from dmke October 6, 2024 03:27
@liuruibin
Copy link
Contributor

Thanks 👍

@ldez ldez merged commit ad96d61 into go-acme:master Oct 7, 2024
7 checks passed
@ldez ldez deleted the volcengine branch October 7, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmke dmke dmke approved these changes

Assignees
No one assigned
Labels
area/dnsprovider enhancement
Milestone
v4.20
Development

Successfully merging this pull request may close these issues.

Support for provider: Volcano Engine
3 participants
@ldez @liuruibin @dmke