[Test] Use ssl.SSLContext.wrap_socket, not ssl.wrap_socket
#33492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter emits a DeprecationWarning since Python 3.10 and is removed in Python 3.12.
musicinmybrain
changed the title
ssl.SSLContext.wrap_socket, not ssl.wrap_socketssl.SSLContext.wrap_socket, not ssl.wrap_socket
gnossen
approved these changes
Jun 20, 2023
gnossen
added
kokoro:run
release notes: no
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
copybara-service
bot
added
the
imported
gnossen
pushed a commit
that referenced
this pull request
Sep 6, 2023
…33506) This API was [removed in Python 3.12](python/cpython#98040). Fixes Python 3.12 support in `grpcio` tests. This is relevant to #33063. See also #33492. ---- I have actually only tested this in a form backported to grpc 1.48.4, and I am not able to test the change to `bazel/_gevent_test_main.py` directly. However, the backported form allows me to build grpc 1.48.4 for Fedora Rawhide with Python 3.12, and I believe the version in this PR to be correct—especially, if CI passes for Python 3.11, I believe this part of the test code will continue to work in Python 3.12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the HTTP(S) test server in the core tests, use
ssl.SSLContext.wrap_socket, notssl.wrap_socket. The latter emits aDeprecationWarningsince Python 3.10 and is removed in Python 3.12.This fixes the core tests (but not necessarily the
grpciotests) for Python 3.12.This is relevant to #33063.