Implements new download manager and HLS downloads (Closes #267) #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a completely new media download manager that can download videos in different formats using different engines.
Using
AVAssetDownloadURLSession, the app is now able to download the HLS variant for videos that offer it (most recent videos do).With the new "Download videos with subtitles" option enabled in the app's settings, the app will download the HLS variant, which includes subtitles.
This variant has a couple of downsides when compared to the traditional HD mp4 variant, so it's disabled by default.
Downsides include slower seek performance and the inability to export clips, however offline playback works just fine and with the advantage that subtitles are included with the offline video.