You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In review mode, clicking on any file in "changes in pull request" at all will yield the error "We couldn't find commit", and the diff will be empty or just contain the full text of the remote file.
to reproduce:
open a project with no submodules
check out a pull request locally, verify that the review mode generally works
close vscode
use git submodule add to add a submodule. (e.g.: make a local checkout of a different git repo, then in the original one, git submodule add ../path/to/checkout submodule1)
open vscode again
Github Pull Request extension is now confused and not showing any PRs
navigate to Source Control and make sure only the original repository, not the submodule, is selected
go back to Github Pull Request extension, see that PRs are visible again
in "changes in pull request" (should be available from last time), click on any file. The "we couldn't find commit" message will pop up and the display will be wrong.
The commits in question exist (as can be verified by git in the command line), but the "Git" output window shows errors on them. Presumably the commands are called on the wrong repository.
The problem affects the stable version of the extension as well.
Extension version: 2020.2.8161
VS Code version: Code 1.42.1 (c47d83b293181d9be64f27ff093689e8e7aed054, 2020-02-11T14:50:36.977Z)
OS version: Linux x64 4.15.0-88-generic
System Info
Item
Value
CPUs
Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz (8 x 2654)
I made a change to fix another submodules issue, and with that fix I can no longer reproduce this issue. Fix will be available in tomorrow's pre-release version of the extension.
Issue Type: Bug
In review mode, clicking on any file in "changes in pull request" at all will yield the error "We couldn't find commit", and the diff will be empty or just contain the full text of the remote file.
to reproduce:
git submodule add
to add a submodule. (e.g.: make a local checkout of a different git repo, then in the original one,git submodule add ../path/to/checkout submodule1
)The commits in question exist (as can be verified by
git
in the command line), but the "Git" output window shows errors on them. Presumably the commands are called on the wrong repository.The problem affects the stable version of the extension as well.
Extension version: 2020.2.8161
VS Code version: Code 1.42.1 (c47d83b293181d9be64f27ff093689e8e7aed054, 2020-02-11T14:50:36.977Z)
OS version: Linux x64 4.15.0-88-generic
System Info
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: unavailable_off
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
The text was updated successfully, but these errors were encountered: