Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASAN failure was detected while running test_threading #104472

Closed
corona10 opened this issue May 14, 2023 · 9 comments · Fixed by #104667
Closed

ASAN failure was detected while running test_threading #104472

corona10 opened this issue May 14, 2023 · 9 comments · Fixed by #104667
Labels
type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@corona10
Copy link
Member

corona10 commented May 14, 2023 •
edited by bedevere-bot
Loading

See: https://github.com/python/cpython/actions/runs/4971544925/jobs/8896154582
Unicodeobject looks quite related.


2023-05-14T09:18:05.5991524Z Direct leak of 1702 byte(s) in 27 object(s) allocated from:
2023-05-14T09:18:05.5991966Z     #0 0x7fb1e4894c47 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
2023-05-14T09:18:05.5992397Z     #1 0x55f4ae5903f7 in PyUnicode_New Objects/unicodeobject.c:1207
2023-05-14T09:18:05.5992778Z     #2 0x55f4ae5f3da8 in PyUnicode_New Objects/unicodeobject.c:1156
2023-05-14T09:18:05.5993182Z     #3 0x55f4ae5f3da8 in unicode_decode_utf8 Objects/unicodeobject.c:4537
2023-05-14T09:18:05.5993607Z     #4 0x55f4ae4e689a in PyDict_SetItemString Objects/dictobject.c:3914
2023-05-14T09:18:05.5994016Z     #5 0x55f4ae858ed0 in setup_confname_table Modules/posixmodule.c:13345
2023-05-14T09:18:05.5994429Z     #6 0x55f4ae858ed0 in setup_confname_tables Modules/posixmodule.c:13367
2023-05-14T09:18:05.5994830Z     #7 0x55f4ae858ed0 in posixmodule_exec Modules/posixmodule.c:16663
2023-05-14T09:18:05.5995232Z     #8 0x55f4ae510890 in PyModule_ExecDef Objects/moduleobject.c:440
2023-05-14T09:18:05.5995683Z     #9 0x55f4ae75cc7a in _imp_exec_builtin (/home/runner/work/cpython/cpython/python+0x72fc7a)
2023-05-14T09:18:05.5996126Z     #10 0x55f4ae50b4dc in cfunction_vectorcall_O Objects/methodobject.c:509
2023-05-14T09:18:05.5996568Z     #11 0x55f4ae42a4c6 in PyObject_Call (/home/runner/work/cpython/cpython/python+0x3fd4c6)
2023-05-14T09:18:05.6133164Z     #12 0x55f4ae2de55d in _PyEval_EvalFrameDefault Python/bytecodes.c:3157
2023-05-14T09:18:05.6134128Z     #13 0x55f4ae42415e in _PyObject_VectorcallTstate Include/internal/pycore_call.h:92
2023-05-14T09:18:05.6134546Z     #14 0x55f4ae42415e in object_vacall Objects/call.c:850
2023-05-14T09:18:05.6134938Z     #15 0x55f4ae427dfe in PyObject_CallMethodObjArgs Objects/call.c:911
2023-05-14T09:18:05.6135351Z     #16 0x55f4ae766927 in import_find_and_load Python/import.c:2715
2023-05-14T09:18:05.6135778Z     #17 0x55f4ae766927 in PyImport_ImportModuleLevelObject Python/import.c:2798
2023-05-14T09:18:05.6136174Z     #18 0x55f4ae2fb183 in import_name Python/ceval.c:2386
2023-05-14T09:18:05.6136645Z     #19 0x55f4ae2fb183 in _PyEval_EvalFrameDefault Python/bytecodes.c:2031
2023-05-14T09:18:05.6137070Z     #20 0x55f4ae6cf786 in _PyEval_EvalFrame Include/internal/pycore_ceval.h:87
2023-05-14T09:18:05.6137459Z     #21 0x55f4ae6cf786 in _PyEval_Vector Python/ceval.c:1611
2023-05-14T09:18:05.6137826Z     #22 0x55f4ae6cf786 in PyEval_EvalCode Python/ceval.c:567
2023-05-14T09:18:05.6138204Z     #23 0x55f4ae6c9061 in builtin_exec_impl Python/bltinmodule.c:1079
2023-05-14T09:18:05.6138615Z     #24 0x55f4ae6c9061 in builtin_exec Python/clinic/bltinmodule.c.h:586
2023-05-14T09:18:05.6139068Z     #25 0x55f4ae50c015 in cfunction_vectorcall_FASTCALL_KEYWORDS Objects/methodobject.c:438
2023-05-14T09:18:05.6139533Z     #26 0x55f4ae424f8f in _PyObject_VectorcallTstate Include/internal/pycore_call.h:92
2023-05-14T09:18:05.6139944Z     #27 0x55f4ae424f8f in PyObject_Vectorcall Objects/call.c:325
2023-05-14T09:18:05.6140349Z     #28 0x55f4ae2db394 in _PyEval_EvalFrameDefault Python/bytecodes.c:2609
2023-05-14T09:18:05.6140941Z     #29 0x55f4ae42415e in _PyObject_VectorcallTstate Include/internal/pycore_call.h:92
2023-05-14T09:18:05.6141332Z     #30 0x55f4ae42415e in object_vacall Objects/call.c:850
2023-05-14T09:18:05.6141720Z     #31 0x55f4ae427dfe in PyObject_CallMethodObjArgs Objects/call.c:911
2023-05-14T09:18:05.6142136Z     #32 0x55f4ae766927 in import_find_and_load Python/import.c:2715
2023-05-14T09:18:05.6142564Z     #33 0x55f4ae766927 in PyImport_ImportModuleLevelObject Python/import.c:2798
2023-05-14T09:18:05.6142967Z     #34 0x55f4ae2fb183 in import_name Python/ceval.c:2386
2023-05-14T09:18:05.6143360Z     #35 0x55f4ae2fb183 in _PyEval_EvalFrameDefault Python/bytecodes.c:2031
2023-05-14T09:18:05.6143799Z     #36 0x55f4ae42490f in _PyObject_VectorcallTstate Include/internal/pycore_call.h:92
2023-05-14T09:18:05.6144249Z     #37 0x55f4ae42490f in _PyObject_CallNoArgsTstate Include/internal/pycore_call.h:99
2023-05-14T09:18:05.6144663Z     #38 0x55f4ae42490f in _PyObject_CallFunctionVa Objects/call.c:535
2023-05-14T09:18:05.6145036Z     #39 0x55f4ae4262e3 in callmethod Objects/call.c:634
2023-05-14T09:18:05.6145400Z     #40 0x55f4ae4262e3 in PyObject_CallMethod Objects/call.c:653
2023-05-14T09:18:05.6145797Z     #41 0x55f4ae769ca2 in init_importlib_external Python/import.c:2265
2023-05-14T09:18:05.6146192Z     #42 0x55f4ae769ca2 in _PyImport_InitExternal Python/import.c:3186
2023-05-14T09:18:05.6146587Z     #43 0x55f4ae7b30f3 in init_interp_main Python/pylifecycle.c:1116
2023-05-14T09:18:05.6146981Z     #44 0x55f4ae7b48c4 in pyinit_main Python/pylifecycle.c:1227
2023-05-14T09:18:05.6147395Z     #45 0x55f4ae7b76af in Py_InitializeFromConfig Python/pylifecycle.c:1258
2023-05-14T09:18:05.6147773Z     #46 0x55f4ae829c19 in pymain_init Modules/main.c:67

cc @gpshead

Linked PRs
@corona10 corona10 added the type-crash A hard crash of the interpreter, possibly with a core dump label May 14, 2023
@sunmy2019
Copy link
Member

cpython leaks many things, and memory leaks are usually suppressed by environment variables:

env:
  ASAN_OPTIONS: detect_leaks=0:allocator_may_return_null=1:handle_segv=0

@sunmy2019
Copy link
Member

sunmy2019 commented May 14, 2023 •
edited
Loading

Somehow the env is not set correctly in this test. May be cleared by some previous tests.

@sunmy2019
Copy link
Member

This issue cannot be reproduced in the following build bot tests.

I think the only thing we can do here is to ensure the env is not changed. But since it's not occurring, it may not be worth doing this.

@chgnrdv
Copy link
Contributor

chgnrdv commented May 19, 2023

I can reproduce this leak with current main on my machine, along with a large number of other leaks related to PyUnicode_New. I'm not competent enough, but I think that some of them may be caused by the fact that Python frees interned heap-allocated strings at interpreter finalization only if it is build with Py_DEBUG defined. It doesn't explain why ASAN failed on this particular test though.

@corona10
Copy link
Member Author

cc @methane

@sunmy2019
Copy link
Member

I can reproduce this leak with current main on my machine

even with leak_detect suppressed?

@chgnrdv
Copy link
Contributor

chgnrdv commented May 19, 2023

Ah, it doesn't leak when I suppress leak detection with ASAN_OPTIONS set. @corona10 @sunmy2019, sorry for the noise.

@chgnrdv
Copy link
Contributor

chgnrdv commented May 19, 2023 •
edited
Loading

OK, seems like I can reproduce this by running only this particular test case:

export ASAN_OPTIONS="detect_leaks=0:allocator_may_return_null=1:handle_segv=0"
./python -m unittest test.test_subprocess.ProcessTestCase.test_empty_env

@sunmy2019
Copy link
Member

OK, seems like I can reproduce this by running only this particular test case:

Indeed. We should skip it.

from test.support import check_sanitizer


    @unittest.skipIf(check_sanitizer(address=True),
                     'AddressSanitizer cannot be runned with empty env')

@chgnrdv chgnrdv mentioned this issue May 19, 2023
Merged
gpshead pushed a commit that referenced this issue May 19, 2023
@chgnrdv
gh-104472: Skip test_subprocess.ProcessTestCase.test_empty_env if A…
c3f43bf 
…SAN is enabled (#104667)

Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled.
@bedevere-bot bedevere-bot mentioned this issue May 19, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 19, 2023
@chgnrdv @miss-islington
pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env…
7ba3f68 
…` if ASAN is enabled (pythonGH-104667)

Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled.
(cherry picked from commit c3f43bf)

Co-authored-by: chgnrdv <[email protected]>
@bedevere-bot bedevere-bot mentioned this issue May 19, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 19, 2023
@chgnrdv @miss-islington
pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env…
6b2fd93 
…` if ASAN is enabled (pythonGH-104667)

Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled.
(cherry picked from commit c3f43bf)

Co-authored-by: chgnrdv <[email protected]>
gpshead pushed a commit that referenced this issue May 19, 2023
@miss-islington @chgnrdv
[3.10] gh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_en…
f9d2a10 
…v` if ASAN is enabled (GH-104667) (#104669)

gh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (GH-104667)

Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled.
(cherry picked from commit c3f43bf)

Co-authored-by: chgnrdv <[email protected]>
gpshead pushed a commit that referenced this issue May 19, 2023
@miss-islington @chgnrdv
[3.11] gh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_en…
2801b3f 
…v` if ASAN is enabled (GH-104667) (#104673)

gh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (GH-104667)

Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled.
(cherry picked from commit c3f43bf)

Co-authored-by: chgnrdv <[email protected]>
carljm added a commit to gsallam/cpython_with_perfmap_apii that referenced this issue May 20, 2023
@carljm
Merge branch 'main' into gsallam/main
ea5965a 
* main: (30 commits)
  pythongh-103987: fix several crashes in mmap module (python#103990)
  docs: fix wrong indentation causing rendering error in dis page (python#104661)
  pythongh-94906: Support multiple steps in math.nextafter (python#103881)
  pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (python#104667)
  pythongh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath (pythonGH-103842)
  pythongh-85984: New additions and improvements to the tty library. (python#101832)
  pythongh-104659: Consolidate python examples in enum documentation (python#104665)
  pythongh-92248: Deprecate `type`, `choices`, `metavar` parameters of `argparse.BooleanOptionalAction` (python#103678)
  pythongh-104645: fix error handling in marshal tests (python#104646)
  pythongh-104600: Make type.__type_params__ writable (python#104634)
  pythongh-104602: Add additional test for listcomp with lambda (python#104639)
  pythongh-104640: Disallow walrus in comprehension within type scopes (python#104641)
  pythongh-103921: Rename "type" header in argparse docs (python#104654)
  Improve readability of `typing._ProtocolMeta.__instancecheck__` (python#104649)
  pythongh-96522: Fix deadlock in pty.spawn (python#96639)
  pythonGH-102818: Do not call `PyTraceBack_Here` in sys.settrace trampoline.  (pythonGH-104579)
  pythonGH-103545: Add macOS specific constants for ``os.setpriority`` to ``os`` (python#104606)
  pythongh-104623: Update macOS installer to SQLite 3.42.0 (pythonGH-104624)
  pythongh-104619: never leak comprehension locals to outer locals() (python#104637)
  pythongh-104602: ensure all cellvars are known up front (python#104603)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-104472: Skip test_subprocess.ProcessTestCase.test_empty_env if ASAN is enabled chgnrdv/cpython
3 participants
@corona10 @chgnrdv @sunmy2019