Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argparse.BooleanOptionalAction accepts and silently discards choices, metavar, and type arguments #92248

Closed
samwyse opened this issue May 3, 2022 · 0 comments
Closed

argparse.BooleanOptionalAction accepts and silently discards choices, metavar, and type arguments #92248

samwyse opened this issue May 3, 2022 · 0 comments
Assignees
@sobolevn
Labels
type-bug An unexpected behavior, bug, or error

Comments

@samwyse
Copy link
Contributor

samwyse commented May 3, 2022 •
edited by bedevere-bot
Loading

This is an elaboration of issue #85039.

>>> parser = ArgumentParser()
>>> parser.add_argument('--foo', action=BooleanOptionalAction,
...     choices=[1,2], metavar='FOOBAR', type=int)  # doctest: +ELLIPSIS
BooleanOptionalAction(...)

Note that the store_const, store_true, and store_false actions disallow those keyword arguments.

>>> parser.add_argument('--bar', action='store_true', choices=[1,2])
Traceback (most recent call last):
  ...
TypeError: __init__() got an unexpected keyword argument 'choices'
>>> parser.add_argument('--bar', action='store_true', metavar='FOOBAR')
Traceback (most recent call last):
  ...
TypeError: __init__() got an unexpected keyword argument 'metavar'
>>> parser.add_argument('--bar', action='store_true', type=int)
Traceback (most recent call last):
  ...
TypeError: __init__() got an unexpected keyword argument 'type'
>>> parser.add_argument('--bar', action='store_true')  # doctest: +ELLIPSIS
_StoreTrueAction(...)

Linked PRs
@samwyse samwyse added the type-bug An unexpected behavior, bug, or error label May 3, 2022
@sobolevn sobolevn self-assigned this Apr 22, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 22, 2023
@sobolevn
pythongh-92248: Deprecate type, chocies, metavar parameters of …
5524230 
…`argparse.BooleanOptionalAction`
@bedevere-bot bedevere-bot mentioned this issue Apr 22, 2023
Merged
hugovk added a commit that referenced this issue May 19, 2023
@sobolevn @Eclips4
@hugovk @arhadthedev
gh-92248: Deprecate type, choices, metavar parameters of `argpa…
27a7d5e 
…rse.BooleanOptionalAction` (#103678)

Co-authored-by: Kirill <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Oleg Iarygin <[email protected]>
carljm added a commit to gsallam/cpython_with_perfmap_apii that referenced this issue May 20, 2023
@carljm
Merge branch 'main' into gsallam/main
ea5965a 
* main: (30 commits)
  pythongh-103987: fix several crashes in mmap module (python#103990)
  docs: fix wrong indentation causing rendering error in dis page (python#104661)
  pythongh-94906: Support multiple steps in math.nextafter (python#103881)
  pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (python#104667)
  pythongh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath (pythonGH-103842)
  pythongh-85984: New additions and improvements to the tty library. (python#101832)
  pythongh-104659: Consolidate python examples in enum documentation (python#104665)
  pythongh-92248: Deprecate `type`, `choices`, `metavar` parameters of `argparse.BooleanOptionalAction` (python#103678)
  pythongh-104645: fix error handling in marshal tests (python#104646)
  pythongh-104600: Make type.__type_params__ writable (python#104634)
  pythongh-104602: Add additional test for listcomp with lambda (python#104639)
  pythongh-104640: Disallow walrus in comprehension within type scopes (python#104641)
  pythongh-103921: Rename "type" header in argparse docs (python#104654)
  Improve readability of `typing._ProtocolMeta.__instancecheck__` (python#104649)
  pythongh-96522: Fix deadlock in pty.spawn (python#96639)
  pythonGH-102818: Do not call `PyTraceBack_Here` in sys.settrace trampoline.  (pythonGH-104579)
  pythonGH-103545: Add macOS specific constants for ``os.setpriority`` to ``os`` (python#104606)
  pythongh-104623: Update macOS installer to SQLite 3.42.0 (pythonGH-104624)
  pythongh-104619: never leak comprehension locals to outer locals() (python#104637)
  pythongh-104602: ensure all cellvars are known up front (python#104603)
  ...
@sobolevn sobolevn mentioned this issue May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
type-bug An unexpected behavior, bug, or error
Projects
Argparse issues
Status: Doc issues
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samwyse @sobolevn @hauntsaninja