Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-79940: skip TestGetAsyncGenState on wasm as it requires working sockets #102605

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

tkren
Copy link
Contributor

@tkren tkren commented Mar 11, 2023

Skip TestGetAsyncGenState and restoring of the default event loop policy in test_inspect if platform lacks working socket support.

Fixes #11590

Automerge-Triggered-By: GH:kumaraditya303

Skip `TestGetAsyncGenState` and restoring of the default event loop
policy in `test_inspect` if platform lacks working socket support.

Fixes python#11590
@tkren tkren force-pushed the fix-pr-11590-test-inspect branch from 184f617 to 6ab6bcf Compare March 11, 2023 16:28
@tkren
Copy link
Contributor Author

tkren commented Mar 11, 2023

@kumaraditya303 this is the follow-up PR for #11590

@kumaraditya303
Copy link
Contributor

!buildbot .wasm.

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 6ab6bcf 🤖

The command will test the builders whose names match following regular expression: .*wasm.*

The builders matched are:

  • wasm32-emscripten node (pthreads) PR
  • wasm32-emscripten browser (dynamic linking, no tests) PR
  • wasm32-wasi PR
  • wasm32-emscripten node (dynamic linking) PR

Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we don't need news for this so I removed it.

@kumaraditya303 kumaraditya303 changed the title gh-79940: TestGetAsyncGenState requires working sockets gh-79940: skip TestGetAsyncGenState on wasm as it requires working sockets Mar 11, 2023
@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Head branch was modified. Review and try the merge again..

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 534660f into python:main Mar 11, 2023
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Mar 12, 2023
…rking sockets (pythonGH-102605)

Skip `TestGetAsyncGenState` and restoring of the default event loop policy in `test_inspect` if platform lacks working socket support.

Fixes python#11590

Automerge-Triggered-By: GH:kumaraditya303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants