-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-97850: remove find_loader
and get_loader
from pkgutil
#119656
base: main
Are you sure you want to change the base?
Conversation
find_loader
and get_loader
from pkgutil
find_loader
and get_loader
from pkgutil
find_loader
and get_loader
from pkgutil
find_loader
and get_loader
from pkgutil
find_loader
and get_loader
from pkgutil
find_loader
and get_loader
from pkgutil
Quick question but how do you manage the whatsnews sections when a feature is being removed? I cannot really change it to |
find_loader
and get_loader
from pkgutil
find_loader
and get_loader
from pkgutil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update
:func:`pkgutil.find_loader`
:func:`pkgutil.get_loader`
to be
:func:`!pkgutil.find_loader`
:func:`!pkgutil.get_loader`
Since all python versions have their own versions of 3.13.rst
/ 3.12.rst
/ etc.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Yes, that's what I was actually asking. Should I just suppress every possible links in the others 3.x.rst files even though they exist? (if so, I can do it but I wanted to be sure that all references should be suppressed even for old versions for which the reference would exist). |
Again, older versions won't be affected, because they live in their own branches. And we won't backport this change. |
Oh yes, it was dumb of me. I incorrectly assumed that the 3.12 page was for the corresponding branch (seems I'm still not entirely awake). Anyway, I have made the requested changes; please review again. |
Thanks for making the requested changes! @sobolevn: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I somehow did not send this comment.
Misc/NEWS.d/next/Library/2024-05-28-14-35-23.gh-issue-97850.dCtjel.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also not sure that we still need this part:
Lines 383 to 385 in 78d697b
# Is this finder PEP 420 compliant? | |
elif hasattr(finder, 'find_loader'): | |
_, portions = finder.find_loader(final_name) |
Domain experts need to verify that.
I think we don't but I haven't tested or investigated deeply. |
I'm not an expert in this since this predates the time when I started coding in Python (technically speaking, I've coded in 2.7 but never in 3.0 -- 3.5). AFAIK, the The main reason is: In particular, having removed |
Co-authored-by: Hugo van Kemenade <[email protected]>
This has a conflict after the #122085 re-org. |
Oh, I forgot about this one :') I'll fix the conflicts err... I don't know when (I'm a bit busy writing something currently and don't know if I'll have tomorrow) |
Thanks, absolutely no rush with this :) |
…n into remove-deprecated-pkgutil
#123036 |
@picnixz are you waiting on anything for this? You haven't triggered a request for a re-review. |
Oh I forgot about it. This one is a low-priority task (which is why I didn't re-request a review) and we were waiting for more experts feedback (such as yours I think?) so we can address this issue when people have the time! (I'll be barely present for the rest of the week) |
See:
📚 Documentation preview 📚: https://cpython-previews--119656.org.readthedocs.build/