Skip to content
New issue

Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Allow manual renderer listens to contribute to event… #56799

Closed
wants to merge 1 commit into from
Closed

refactor(core): Allow manual renderer listens to contribute to event… #56799

wants to merge 1 commit into from

Conversation

iteriani
Copy link
Contributor

@iteriani iteriani commented Jul 1, 2024

…delegation as well.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jul 1, 2024
@ngbot ngbot bot added this to theBacklogmilestone Jul 1, 2024
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 2, 2024
thePunderWoman
thePunderWoman approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM on this! Looks like there's some test failures, though.

@iteriani
refactor(core): Allow manual renderer listens to contribute to event…
790650b 
…delegation as well.

There are existing usages that inject the renderer to manualy listen (often for event
delegation purposes). These should contribute as well.
@iteriani
Copy link
Contributor Author

oops done

@iteriani iteriani removed the request for review fromAndrewKushnir July 16, 2024 23:17
@iteriani iteriani added the action: merge The PR is ready for merge by the caretaker label Jul 16, 2024
@atscott atscott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 19, 2024
@atscott
Copy link
Contributor

atscott commented Jul 19, 2024

This PR was merged into the repository by commit3664cd6.

The changes were merged into the following branches: main, 18.1.x

@atscott atscott closed this in 3664cd6 Jul 19, 2024
atscott pushed a commit that referenced this pull request Jul 19, 2024
@iteriani @atscott
refactor(core): Allow manual renderer listens to contribute to event…
142c2df 
…delegation as well. (#56799)

There are existing usages that inject the renderer to manualy listen (often for event
delegation purposes). These should contribute as well.

PRClose#56799
vladboisa pushed a commit to vladboisa/angular that referenced this pull request Jul 29, 2024
@iteriani @vladboisa
refactor(core): Allow manual renderer listens to contribute to event…
6d7bf81 
…delegation as well. (angular#56799)

There are existing usages that inject the renderer to manualy listen (often for event
delegation purposes). These should contribute as well.

PRCloseangular#56799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iteriani @atscott @thePunderWoman @AndrewKushnir