Skip to content
New issue

Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] LeastActiveLoadBalance does not properly utilize weights. #14406

Open
4 tasks done
howie-xuopened this issue Jul 9, 2024 · 4 comments
Open
4 tasks done

[Feature] LeastActiveLoadBalance does not properly utilize weights. #14406

howie-xuopened this issue Jul 9, 2024 · 4 comments
Assignees
@howie-xu
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@howie-xu
Copy link
Contributor

howie-xu commented Jul 9, 2024 •
edited
Loading

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in theissuesand found no similar feature requirement.

Apache Dubbo Component

Java SDK (apache/dubbo)

Descriptions

In LeastActiveLoadBalance, instances are first filtered by the minimum number of active connections. If there is more than one instance with the minimum number of active connections, a random selection is made based on weights. This design seems somewhat unreasonable, and the warmup feature doesn't have much effect (a batch of instances that are restarted or scaled up will still suddenly receive a large number of requests). Could we use the weights more effectively during the minimum connection filtering phase, for example, by using active * afterWarmup to determine the least active instance?

Related issues

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct
@howie-xu howie-xu added component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage labels Jul 9, 2024
@wcy666103
Copy link
Contributor

Please submit in English Only

@howie-xu howie-xu changed the title Version: [3.2], LeastActiveLoadBalance chưa hợp lý sử dụng quyền trọng Version: [3.2], LeastActiveLoadBalance does not properly utilize weights. Jul 9, 2024
@howie-xu howie-xu changed the title Version: [3.2], LeastActiveLoadBalance does not properly utilize weights. [Feature] LeastActiveLoadBalance does not properly utilize weights. Jul 9, 2024
@AlbumenJ
Copy link
Member

Yes, we need a new algorithm

@howie-xu
Copy link
Contributor Author

howie-xu commented Jul 10, 2024 •
edited
Loading

Can the actual number of active be directly changed to "active * afterWarmup" in the LeastActiveLoadBalance?

howie-xu added a commit to howie-xu/dubbo that referenced this issue Jul 11, 2024
@howie-xu
Add the WeightedLeastActiveLoadBalance algorithm (apache#14406)
88c462d
@howie-xu howie-xu mentioned this issue Jul 11, 2024
Open
8 tasks
howie-xu added a commit to howie-xu/dubbo that referenced this issue Jul 11, 2024
@howie-xu
Add the WeightedLeastActiveLoadBalance algorithm (apache#14406)
4250ae8
howie-xu added a commit to howie-xu/dubbo that referenced this issue Jul 11, 2024
@howie-xu
Add the WeightedLeastActiveLoadBalance algorithm (apache#14406)
e8f27bf
howie-xu added a commit to howie-xu/dubbo that referenced this issue Jul 11, 2024
@howie-xu
Add the WeightedLeastActiveLoadBalance algorithm (apache#14406)
0a845f5
howie-xu added a commit to howie-xu/dubbo that referenced this issue Jul 11, 2024
@howie-xu
Add the WeightedLeastActiveLoadBalance algorithm (apache#14406)
770b84a
howie-xu added a commit to howie-xu/dubbo that referenced this issue Jul 11, 2024
@howie-xu
Add the WeightedLeastActiveLoadBalance algorithm (apache#14406)
2c46b7b
@AlbumenJ
Copy link
Member

Can the actual number of active be directly changed to "active * afterWarmup" in the LeastActiveLoadBalance?

This may be not well enough. Inactive * afterWarmup,the newly launched node will get lower score and will be more high weighed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@howie-xu howie-xu

Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Dubbo Board
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlbumenJ @howie-xu @wcy666103