Skip to content
New issue

Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Add online and ready functions based on Spring Boot Actuator #14399

Open
wants to merge 8 commits into
base: 3.3
Choose a base branch
from

Conversation

JinQian1024
Copy link

What is the purpose of the change

It implements the online (to be improved) and ready functions based on Spring Boot Actuator and equivalent to the QoS functions

Brief changelog

Verifying this change

Checklist

  • Make sure there is aGitHub_issuefield for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample indubbo samplesproject.
  • Add some description todubbo-websiteproject if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow theSoftware Donation Guide.

@@ -45,7 +47,7 @@
@Configuration
@PropertySource(
name = "Dubbo Endpoints Default Properties",
value = "classpath:/META-INF/dubbo-endpoints-default.properties" )
value = "classpath:/META-INF/dubbo-endpoints-default"+".properties ")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why change this

*
* @since 3.3.0
*/
@Endpoint(id = "dubboonline" )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

offline is also useful

…ace,loggerInfo,Ls,switchLogger,switchLogLevel
@JinQian1024 JinQian1024 reopened this Jul 31, 2024
Copy link

sonarcloud bot commented Aug 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants