Development Keys #8378
Draft
Development Keys #8378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meldiron
reviewed
Aug 6, 2024
app/controllers/shared/api.php
Outdated
| @@ -292,6 +292,37 @@ | |||
| } | |||
| } | |||
| } | |||
| } elseif($keyType === API_KEY_TEST) { | |||
| var_dump('keys matches test'); | |||
Meldiron
reviewed
Aug 6, 2024
app/controllers/shared/api.php
Outdated
Comment on lines
316
to
317
| Authorization::setRole(Auth::USER_ROLE_ADMIN); | ||
| Authorization::setDefaultStatus(false); // Cancel security segmentation for API keys. |
There was a problem hiding this comment.
Im not sure what development keys are for. Are they like API keys but for Console user - giving access to all project and project/organization actions?
Meldiron
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Curious, why not just XList?
There was a problem hiding this comment.
Do you mean why not justList?Listappears to be a keyword.
Meldiron
reviewed
Aug 6, 2024
| 'x-appwrite-project' => $this->getProject()['$id'], | ||
| ], $this->getHeaders()), [ | ||
| 'name' => 'Key Test', | ||
| 'expire' => DateTime::addSeconds(new \DateTime(), 36000) |
There was a problem hiding this comment.
Let's expire in 10 seconds. After tests have sleep for 10 seconds, and try to use it to get failure.
✨ Benchmark results
⚡ Benchmark Comparison
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does and why it's needed.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)
Related PRs and Issues
Checklist