-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use organization default fixedPrice if self-serve/default price is passed in #15966
Merged
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
billing
area: billing, stripe, payments, paypal, get paid
platform
Anything related to our platform plan
labels
Jul 29, 2024
The latest updates on your projects.Learn more aboutVercel for Git ↗︎
2 Skipped Deployments
|
Graphite Automations"Add consumer team as reviewer"took an action on this PR • (07/29/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer"took an action on this PR • (07/29/24)1 reviewer was added to this PR based on Keith Williams's automation. |
hariombalhara
previously approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM now!!
hariombalhara
approved these changes
Aug 7, 2024
zomars
pushed a commit
that referenced
this pull request
Aug 7, 2024
…is passed in (#15966) * Use fixed price if default (selfserve) is used * fix conditional * use.env instead of hard coded values * feedback
zomars
pushed a commit
that referenced
this pull request
Aug 7, 2024
…is passed in (#15966) * Use fixed price if default (selfserve) is used * fix conditional * use.env instead of hard coded values * feedback
PeerRich
added a commit
that referenced
this pull request
Aug 8, 2024
* fix: uncaught errors in PaymentService * fix: uncaught errors in WebhookService * fix: uncaught errors in sendPayload * fix: uncaught PaymentService typings in payment utils * fix: Remove missing users from assignment (#16115) * remove missing users from assignment * early return * fix: use organization default fixedPrice if self-serve/default price is passed in (#15966) * Use fixed price if default (selfserve) is used * fix conditional * use.env instead of hard coded values * feedback * fix: display skeleton loader (#16114) * fix: display loader * fix: updated skelton loader * feat: create new markNoShow endpoint (#15738) * feat: create new markNoShow endpoint * chore: add schema * chore: update name * chore: save progress * refactor: improve code and types * fix: unit test * chore: improvements * chore: move query to booking repository * fix: type error * chore: Remove cal.ai email assistant (#16003) * Delete apps/ai directory * removed cal-ai app from app store --------- Co-authored-by: Anik Dhabal Babu <[email protected] > Co-authored-by: Carina Wollendorfer <[email protected] > Co-authored-by: Hariom Balhara <hariombalhara@gmail > * feat: Add upcoming bookings feature to GET /api/bookings endpoint (#16060) * feat: Add upcoming bookings feature to GET /api/bookings endpoint - Added support for filtering upcoming bookings by adding the `upcoming` query parameter to the GET /api/bookings endpoint. - When `upcoming` is set to "true", only upcoming bookings are returned. - Regular users can now retrieve only their upcoming bookings by setting `upcoming` to "true". - System-wide admins and organization admins can also retrieve only upcoming bookings by setting `upcoming` to "true". * feat: Add status filter to booking API endpoint This commit adds a new `status` filter to the booking API endpoint. The `status` filter allows filtering bookings by their status, overriding the `dateFrom` and `dateTo` filters. The only valid value for the `status` filter is "upcoming". * Update _get.ts --------- Co-authored-by: Anik Dhabal Babu <[email protected] > * fix: Hide personal booking theme when in an organization (#16117) Co-authored-by: Peer Richelsen <peeroke@gmail > * fix: uncaught errors in WebhookService * fix: uncaught errors in sendPayload --------- Co-authored-by: Syed Ali Shahbaz <[email protected] > Co-authored-by: sean-brydon <[email protected] > Co-authored-by: Udit Takkar <[email protected] > Co-authored-by: Peer Richelsen <peeroke@gmail > Co-authored-by: Anik Dhabal Babu <[email protected] > Co-authored-by: Carina Wollendorfer <[email protected] > Co-authored-by: Hariom Balhara <hariombalhara@gmail > Co-authored-by: Imamuzzaki Abu Salam <imamuzzaki@gmail > Co-authored-by: Joe Au-Yeung <[email protected] >
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
billing
area: billing, stripe, payments, paypal, get paid
consumer
core
area: core, team members only
❗️.env changes
contains changes to env variables
platform
Anything related to our platform plan
ready-for-e2e
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Create an Organization via self serve flow
Check stripe to ensure subscription gets added to the fixed priceId
Create an Organization via the admin flow
Check to see custom price has been created under the product.