feat(deno.json-importMap[deno add]): support inserting added dependencies into import map file when specified instead of deno.json #24478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies to the import map file rather than imports in deno.json
|
@dsherretcan you please take a look at this one? |
|
@HasanAlrimawisorry, but we're going to decline this one for now. See the reasoning in#24264 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR servesas a starting pointfor addressing issue#24264.
Flow
when using
deno add "something",the program checksdeno.jsonto see if it includesimportMap keyand if it does, the program adds the dependency there. However, ifdeno.jsondoesn't include the key, then the program adds the dependency under the imports key indeno.json.Further work
If this feature is to be fully implemented using the approach in this PR, then the implementer should: