Skip to content
New issue

Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go] UI fixes and tweaks #30330

Merged
merged 2 commits into from
Jul 22, 2024
Merged

[go] UI fixes and tweaks #30330

merged 2 commits into from
Jul 22, 2024

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Jul 10, 2024 •
edited by FiberJW
Loading

Why

There are some slight inconsistencies across the Expo Go interface; let's address that.

How

The following changes have been made:

  • unify the default background color of screens
  • Fix account modal appearance, tweak the iOS header
  • fix spacing issues on the Home and Settings screens
  • tweak the labels and wording around supported SDK
  • add missing tab bar border

Test Plan

The changes have been reviewed by running a debug build of Expo Go locally.

Preview

RPReplay_Final1720639245.MP4

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jul 10, 2024
@Simek Simek marked this pull request as ready for review July 10, 2024 19:31
@Simek Simek requested a review fromFiberJW July 10, 2024 20:06
FiberJW
FiberJW approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@FiberJW FiberJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This generally looks good, but I'd want you to verify that these changes look as you intended on Android before merging

apps/expo-go/src/screens/SettingsScreen/ConstantsSection.tsx Show resolved Hide resolved
apps/expo-go/src/components/NavigationScrollView.tsx Show resolved Hide resolved
@Simek
Copy link
Collaborator Author

Simek commented Jul 22, 2024

Android

Screenshot_20240722-222437

Screenshot_20240722-223058

Screenshot_20240722-222759

@FiberJW FiberJW self-requested a review July 22, 2024 20:33
FiberJW
FiberJW approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@FiberJW FiberJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for verifying that Android renders as intended! Let's ship it!

@Simek Simek merged commitf4999bc into main Jul 22, 2024
2 checks passed
@Simek Simek deleted the @simek/go-ui-tweaks-and-fixes branch July 22, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FiberJW FiberJW FiberJW approved these changes

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Simek @FiberJW @expo-bot