Skip to content
New issue

Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[router]: add maestro tests #30568

Merged
merged 4 commits into from
Aug 29, 2024
Merged

[router]: add maestro tests #30568

merged 4 commits into from
Aug 29, 2024

Conversation

marklawlor
Copy link
Contributor

Why

Add test suite for Expo Router maestro tests

How

Test Plan

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jul 22, 2024
@marklawlor marklawlor force-pushed the marklawlor/router/maestro-tests branch from 634e62c to e56ff25 Compare July 29, 2024 21:07
@marklawlor marklawlor marked this pull request as ready for review July 29, 2024 21:32
Copy link
Contributor

@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's rename the "maestro" test to something more specific to the functionality that we're testing.

@marklawlor marklawlor merged commit7d4c2e8 into main Aug 29, 2024
1 check passed
@marklawlor marklawlor deleted the marklawlor/router/maestro-tests branch August 29, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants