Skip to content
New issue

Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update Assets guide #30603

Merged
merged 4 commits into from
Aug 26, 2024
Merged

[docs] Update Assets guide #30603

merged 4 commits into from
Aug 26, 2024

Conversation

amandeepmittal
Copy link
Member

Why

Part of the ongoing improvements for docs are under the Develop section.

How

This PR updates the Assets guide by:

  • Restructuring the guide to provide actionable user-facing steps for loading an asset using either the config plugin oruseAssetshook fromexpo-assetlibrary.
  • Also mention these two methods in the section headings.
  • Updating the examples to use TypeScript file extensions by default
  • Updating verbiage.
  • Adding an additional information section and moving sections on optimizing assets and fonts under it.
  • Fix a broken link to the Fonts guide on adding a custom font.

Test Plan

Run docs locally and visit:http://localhost:3002/develop/user-interface/assets

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jul 24, 2024
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! 👍

@amandeepmittal amandeepmittal merged commit5fa639d into main Aug 26, 2024
2 checks passed
@amandeepmittal amandeepmittal deleted the aman/update-assets-guide branch August 26, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants