Skip to content
New issue

Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Bump minimum to iOS 14 #444

Merged
merged 82 commits into from
Jul 30, 2024
Merged

feat!: Bump minimum to iOS 14 #444

Show file tree
Hide file tree
Changes from1 commit
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
5eed6b5
feat!: Bump minimum to iOS 14
wangelaJun 3, 2023
a85b646
chore: correct dependency in SwiftDemoApp
wangelaJun 3, 2023
a050186
chore: downgrade GoogleMaps dependency until version bump
wangelaJun 3, 2023
b1f161e
chore: update images used in workflows
wangelaJun 3, 2023
d9b58a0
chore: release and test workflows
wangelaJun 5, 2023
7cda44d
Merge branch 'main' into wangela/8-0-0
wangelaJun 15, 2023
75da9bb
chore: merge from main
wangelaNov 21, 2023
d18c32d
feat!: update to latest version of GoogleMaps
wangelaNov 21, 2023
ac0d208
chore: update minimum OS
wangelaNov 21, 2023
04441e1
chore: update workflows and README
wangelaNov 29, 2023
91a70c5
chore: update podspec dependency to 8.0 as the floor
wangelaNov 29, 2023
59b3987
docs: update SPM install instructions in README
wangelaDec 14, 2023
a3c0c33
fix: remove version from podspec dependency (restore #277)
wangelaDec 21, 2023
6b7b6ef
chore: update GMSMapView initializer with GMSMapViewOptions
wangelaDec 22, 2023
05b8ef4
chore: migrate from deprecated UIGraphicsBeginImageContext
wangelaDec 22, 2023
0720ccd
chore: update obj-c sample app GMSMapView initializer
wangelaDec 22, 2023
bdf509d
chore: update GMSMapView initializer in dev app
wangelaDec 22, 2023
a1dd9bb
chore: update GMSMapView initializer in test app
wangelaDec 22, 2023
b7c7322
chore: update test since migration to imageRenderer returns non-nil i…
wangelaDec 22, 2023
2ec5f0f
chore: migrate from src and test to Sources and Test
wangelaFeb 2, 2024
85bb458
chore: update header location
wangelaFeb 2, 2024
3a04992
chore: flatten header directory structure
wangelaFeb 2, 2024
04f90b1
chore: exclude platforms from Swift package
wangelaFeb 3, 2024
05fb820
chore: flatten header files
wangelaFeb 3, 2024
ec2033b
chore: move top-level header file
wangelaFeb 3, 2024
5b81e60
chore: fix package manifest and headers
wangelaFeb 3, 2024
5741dbf
chore: update podspec and xcconfig
wangelaFeb 14, 2024
de4e482
chore: try adding resource bundle
wangelaFeb 15, 2024
46ae0ab
chore: update podspec and package.swift
wangelaMay 11, 2024
9ee1ded
chore: migrate some tests
wangelaMay 11, 2024
d50a005
Added example model of MockMapView..
waynewbishopMay 17, 2024
12d9ff8
Additional notes..
waynewbishopMay 17, 2024
0f1d8f4
chore: restore obj-c tests, add test plan
wangelaMay 24, 2024
340f6b2
chore: snapshot directory
wangelaMay 24, 2024
6662431
chore: snapshot repo
wangelaMay 27, 2024
53163f2
fix: remove old xcodeproj and xcconfig files
wangelaMay 28, 2024
dff8ccc
fix: GMUGradientTest dependency on ObjectiveCTestHelper
wangelaMay 30, 2024
ba950c3
chore: fix typo in naming
wangelaMay 30, 2024
1f23720
fix: add resources for Swift GMUGeoJSONParserTest
wangelaMay 31, 2024
180591f
chore: translate GMUMKLParserTest to Swift
wangelaMay 31, 2024
7f417d3
fix: GMUHeatmapTileLayerTest
wangelaMay 31, 2024
4951e80
chore: update podspec
wangelaMay 31, 2024
37e8677
chore: lower GoogleMaps dependency to minimum 8.0
wangelaMay 31, 2024
d852cbe
chore: update sample apps and test imports
wangelaJun 4, 2024
8580350
chore: try removing extra import
wangelaJun 4, 2024
6ba762a
chore: remove GoogleMapsUtilsSwift dependency from tests
wangelaJun 4, 2024
e35fee3
refactor: name ObjC and Swift targets distinct from parent product
wangelaJun 7, 2024
ac36529
fix: directory name in podspec
wangelaJun 7, 2024
1bfb249
fix: errors in podspec
wangelaJun 7, 2024
b568522
fix: test dependencies in podspec
wangelaJun 7, 2024
50e1c5d
chore: public headers in podspec
wangelaJun 7, 2024
d734924
feat: try making Swift target the default
wangelaJun 7, 2024
c5e3361
chore: freeze state of podspec before deferring cocoapods support unt…
wangelaJun 7, 2024
5b47d20
fix!: remove CocoaPods support
wangelaJul 13, 2024
5f30bc4
chore: consolidate build and test workflows
wangelaJul 16, 2024
db8d6b7
chore: integrate best practices from GitHub Actions template
wangelaJul 16, 2024
0d2c8c1
chore: update README
wangelaJul 16, 2024
434b8b1
chore: convert to release please
wangelaJul 16, 2024
8bc561e
feat: restore CocoaPods support and sample apps in test workflow
wangelaJul 16, 2024
d960508
docs: update README
wangelaJul 16, 2024
049bd25
fix!: Translate HeatMapInterpolationPoints.swift to GMUHeatmapInterpo…
wangelaJul 18, 2024
0fbe683
Revert "fix!: Translate HeatMapInterpolationPoints.swift to GMUHeatma…
wangelaJul 19, 2024
1817503
fix: add Cocoapods version of tests
wangelaJul 19, 2024
986734f
refactor: rename ObjC target and try adding modulemap to expose GMUWe…
wangelaJul 19, 2024
b28d4e8
refactor: add module map to include GMUWeightedLatLng for Swift import
wangelaJul 24, 2024
f47cf2c
chore: rename file
wangelaJul 24, 2024
7d3937a
refactor: module map for GMUWeightedLatLng import by HeatmapInterpola…
wangelaJul 25, 2024
8c35f4c
fix: use exported to expose ObjC to Swift
wangelaJul 25, 2024
88232b2
chore: share tests between SPM and CocoaPods
wangelaJul 26, 2024
6daebd3
fix: fix imports for QuadTree test
wangelaJul 26, 2024
200bead
fix: resource bundle imports for tests run in CocoaPods
wangelaJul 26, 2024
d6fa47f
feat: add privacy manifest (empty)
wangelaJul 26, 2024
442b9a2
chore: update podspect to pre-release values
wangelaJul 26, 2024
9bf10ba
chore: update Podfile template to pre-release state
wangelaJul 26, 2024
d90c984
docs: update README
wangelaJul 29, 2024
790f907
chore: prepare key files for release-please version updates
wangelaJul 30, 2024
6ed960d
chore: add publish workflow
wangelaJul 30, 2024
d478aa4
Merge branch 'main' into wangela-wip
wangelaJul 30, 2024
fbc2d29
chore: remove oboslete files
wangelaJul 30, 2024
6d003f4
chore: update contributing guide
wangelaJul 30, 2024
11a5c19
chore: configure release-please
wangelaJul 30, 2024
3cfe294
chore: fix cocoapods build job
wangelaJul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update workflows and README
  • Loading branch information
@wangela
wangela committed Nov 29, 2023
commit04441e10c832ba62d6623df97208c37b2480b66d
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
run: sudo gem install cocoapods

- name: CocoaPods spec lint
run: podliblint Google-Maps-iOS-Utils.podspec
run: podspeclint Google-Maps-iOS-Utils.podspec
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this shouldn't be changed,lib lintvalidates the local sources,spec lintvalidates a published tag, since this changes are not published you can't properly test


- name: Build DevApp
run: |
Expand Down
8 changes: 1 addition & 7 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,7 @@ jobs:
run: sudo xcode-select -s /Applications/Xcode_14.2.app
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Xcode 15 is a requirement for publishing apps since last week, I think you should test there instead of 14.2


- name: Install Dependencies
run: |
brew install carthage
sudo gem install cocoapods

- name: Carthage update
run: |
carthage build --use-xcframeworks
run: sudo gem install cocoapods

- name: Create XCFramework
run: |
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@ jobs:
- name: Checkout google-maps-ios-utils
uses: actions/checkout@v3

# Lint check on the podspec
- name: Install Dependencies
run: sudo gem install cocoapods

- name: CocoaPods spec lint
run: podliblint Google-Maps-iOS-Utils.podspec
run: podspeclint Google-Maps-iOS-Utils.podspec
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

same as the previous comment, should not be changed,lib lintshould be used


# Run unit tests
- name: Run unit tests
run: |
xcodebuild -scheme UnitTest -configuration Debug -destination "platform=iOS Simulator,OS=16.2,name=iPhone 14" build test | xcpretty
Expand Down
2 changes: 1 addition & 1 deletion Google-Maps-iOS-Utils.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Pod::Spec.new do |s|
s.module_name = "GoogleMapsUtils"
s.swift_version = '5.0'

s.dependency 'GoogleMaps','~> 8.3'
s.dependency 'GoogleMaps'
s.static_framework = true

s.subspec 'QuadTree' do |sp|
Expand Down
2 changes: 1 addition & 1 deletion Podfile.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ platform:ios, '14.0'

target 'YOUR_APPLICATION_TARGET_NAME_HERE' do
use_frameworks!
pod 'GoogleMaps', '8.0.0'
pod 'GoogleMaps', '8.3.0'
pod 'Google-Maps-iOS-Utils', '4.2.2'
end
# [END maps_ios_utils_podfile_template]
29 changes: 28 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ range of applications using the [Google Maps SDK for iOS][sdk].

- iOS 14.0+
- [Maps SDK for iOS][sdk] (see [Releases](https://github /googlemaps/google-maps-ios-utils/releases) for minimum compatible version)
- An [API key](https://developers.google /maps/documentation/ios-sdk/get-api-key)

## Installation

Expand Down Expand Up @@ -54,7 +55,33 @@ pod install

**Note**: This feature is only available with Swift 5.3 (Xcode 12) or later.

Add the following to your `dependencies` value of your `Package.swift` file.
1. Follow the instructions for
[adding package dependencies to your app in Xcode](https://developer.apple /documentation/xcode/adding-package-dependencies-to-your-app).

2. In the "Enter Package URL" field, enter this GitHub repository:

```
https://github /googlemaps/google-maps-ios-utils
```

3. Select the
[version](https://github /googlemaps/google-maps-ios-utils/releases)
of the Maps SDK for iOS Utility Library that you want to use. For new projects, we recommend specifying the latest version and using the "Up to Next Major Version" option.

4. Follow the
[instructions](https://developers.google /maps/documentation/ios-sdk/config#get-key) to add your API key to your app.

Alternatively, you can add the following to the `dependencies` value of your
`Package.swift` file:

```
dependencies: [
.package(
url: "https://github /googlemaps/ios-maps-sdk.git",
.upToNextMajor(from: "8.3.0" )
)
]
```

```
dependencies: [
Expand Down
Loading