api(video): restore the missing video path accessor #4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
I don't think we need this event. We'll very soon need to add things like saveAs, waitForFinished etc. All the CI use cases should work with the existing API where one can specify video folder per context and each test is supposed to use separate context. So I'd wait for more feedback before adding the event back.
pavelfeldman
changed the title
dgozman
approved these changes
Oct 14, 2020
dgozman
changed the title
pavelfeldman
changed the title
aslushnikov
pushed a commit
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes#4131