Update esm-utils.js #5160
Closed
Update esm-utils.js #5160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix CommonJS named export error in esm-utils (Issuemochajs#5156)
|
|
I dont see the changes you mention in your original post |
JoshuaKGoldberg
requested changes
Jul 3, 2024
There was a problem hiding this comment.
👋 the linked issue isn't accepting PRs, so we can't take this PR in. You can read more about this in our.github/CONTRIBUTING.mdfile.Marking as a draft in the meantime.
FWIW I think this fix makes sense if we can have a clean reproduction on the issue... though we will also need a test to validate it actually fixes the issue. 🙂
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CommonJS named export error in esm-utils (Issue#5156)
This PR addresses the issue described in#5156,where a named export error occurs with CommonJS modules. The following changes have been made:
formattedImportfunction inesm-utils.jsto ensure proper handling of CommonJS module imports.requireOrImportto usedealWithExportsfor CommonJS modules.