Start to add node.js only parcel watcher wachman back-end #9789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamadapc
changed the title
yamadapc
force-pushed
the
pyamada-nodejs-watchman-watcher
branch
from
b00711b
to
5099a0d
Compare
marcins
reviewed
Jul 8, 2024
| "test:unit": "cross-env NODE_ENV=test mocha --timeout 5000 && cargo test", | ||
| "test:integration": "yarn workspace @parcel/integration-tests test", | ||
| "test:integration-ci": "yarn workspace @parcel/integration-tests test-ci", | ||
| "test:unit": "lerna run build-ts && cross-env NODE_ENV=test mocha --timeout 5000 && cargo test", |
There was a problem hiding this comment.
You should be able to remove the explicitbuild-ts(which is quite heavy handed) by modifying the parcel babel preset
There was a problem hiding this comment.
I'd rather shift towards split compile and run lifecycle than the current mix of babel register etc.
It's quite confusing at the moment that there is the "dev" register mode and another mode that is pre-built (hence need the dev-prepare steps to fix-up the repository).
|
I'll just make it easy and use JSDoc syntax (?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a commit overv2...jondlm:parcel:jdlm-watchman-drop-in-replacement
Migrated to typescript but need to write some tests and integrate with the rest of the codebase.
The ignore patterns section likely is one thing that needs to be changed carefully though we could support only a subset of the current ignore options and delegate to watchman.