Skip to content
New issue

Have a question about this project?Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of serviceand privacy statement.We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows bundle-time definition of arbitrary path for chunk loading. #17901

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nl-brett-stime
Copy link

Summary

copilot:summary

Details

copilot:walkthrough

Copy link

CLA Not Signed

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@nl-brett-stime
Copy link
Author

Addresses#16447

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is only for Node.js env, do you really want this?

@webpack-bot
Copy link
Contributor

Hi@nl-brett-stime.

Just a little hint from a friendly bot about the best practice when submitting pull requests:

Don't submit pull request from your ownmainbranch. It's recommended to create a feature branch for the PR.

You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.

@nl-brett-stime
Copy link
Author

It is only for Node.js env, do you really want this?

Yeah. The use-case I'm most aware of is with AWS Lambda, which is Node-based. I think similar improvements should be possible on the browser side but my use-case doesn't lend itself to testing additional/new functionality in those scenarios.

@alexander-akait
Copy link
Member

Anyway please add tests case and fix the CI, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants