InT370443#9999210,@vaughnwalterswrote:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CampaignEvents/+/1055295/1/i18n/qqq.json

The above change doesn't include "editors found". Is this intentional? If so, we should change the AC.@Daimona

InT368115#9998433,@gonyeahialamwrote:

@DaimonaCan you expand more on the challenges of having a filter that applies to both events and Wikiprojects even though all the filter options aren't always going to be applicable to both?

(Made the task more general, and added simpler reproduction steps that don't require any extensions)

Button text has been updated and the info chip work is tracked inT370473,moving this back to QA.

InT370181#9993357,@vaughnwalterswrote:

2. Right now when there are no editors theProcessingmessage still displays instead of the0 editors generatedmessage. To reproduce, create a new article in the mainspace and then add that article only to a new invitation list at Special:GenerateInvitationList, then visit Special:MyInvitationLists

I don't think this could happen. I've created multiple invitation lists with just one article and everything works fine. Can you please double check again? I suspect that when you checked the special page, the job for generating the list was still in the queue.

Here is a video of retrying it, and you can see below the other jobs where I tried the same thing that are all still marked as processing:

This is scheduled for Monday 22 at 13:00 UTC.

InT370181#9992590,@vaughnwalterswrote:

1. As seen in the images below, the icons (notice style and success style) should be slightly smaller within the div that contains the classcdx-info-chip

InT356683#9992934,@vaughnwalterswrote:

The button is+Addinstead of+New.Do we just need to update the AC for this or does the copy need to change?

InT364804#9986643,@gonyeahialamwrote:

@Daimona@ifriedanother thing I mentioned above is that we will also need to add the 'view article list' when no editors are generated so that organizers can reference it when creating a new list.

I've looked into the popup thing again. First of all, Codex does not seem to have that popup component:T363375.Also, as I mentioned above, the OOUI version only exists in JavaScript and I'd rather not use it for now. So, for this first version I have the following 2 proposals:

InT364967#9974973,@Umherirrenderwrote:

Happen on CI as well, providing a flaky test.

InT364804#9978069,@ifriedwrote:

• Let's not rewrite the copy; we need to move forward, and I think the current copy works for the MVP.

InT364802#9977630,@gonyeahialamwrote:

Shouldn't the same message for when the list is generated be used for when the list isn't generated?

InT365629#9977404,@gonyeahialamwrote:

InT365629#9975217,@Daimonawrote:

InT365629#9975154,@vaughnwalterswrote:

❓ Noting that Events in the article list get the "The following articles are not in the main namespace." error while other pages that are not in the main namespace (such as Special:EditEventRegistration in this example) get a different error. I think this is probably fine since it does still display an error, but just calling it out here because it is inconsistent. Is this something we would want to fix? It not, we can move this to design sign off.

I think that's a consequence of special pages not being real pages. It'd probably be non-trivial to fix, so I'd vote for leaving it as-is if possible.

I wonder if users will often make the mistake of entering special pages, if they do then the invalid message will not help them identify and solve the problem.

InT364802#9977409,@gonyeahialamwrote:

So the current behaviour mentioned in this task is no longer the current?

InT364802#9977391,@gonyeahialamwrote:

No. I mean that the current expected behaviour is that you always see this message when going to Special:InvitationList, regardless of whether you generated the list or not.

@DaimonaI thought in another task we said we show a specific message to people who didn't create the list but try to assess it?

InT365629#9977357,@gonyeahialamwrote:

If the user enters a Wikidata item name or Category page name, what will be the error?

InT364804#9977060,@gonyeahialamwrote:

@DaimonaWe should use the message component, I was just thinking what message type will be appropriate here - notice, warning or error. I decided to go with 'warning' based on the reasons I describe below, let me know your thoughts.

Actually one more challenge. The CSS-only version of the accordion component does not seem to supportactions.I tried a DIY implementation but clicking the button results in the accordion expanding as well. Also, even in OOUI, the popup button is a JS widget and we're currently refraining from adding JS widgets to this page due toT351818.Could we use the accordiondescriptioninstead?

Also: we need an actual tooltip/alt label for both "info" buttons, so that the purpose of the button is understood by screen readers etc. Something like "Help" or "More information" would do.

InT364804#9974565,@ifriedwrote:

My only concern is that we'll need to create the documentation, which doesn't exist yet, and I would like it to not be a blocker for the task. So how about I remove the link for this task and create a separate task to add in the link when the documentation has been created?

InT365629#9975154,@vaughnwalterswrote:

❓ Noting that Events in the article list get the "The following articles are not in the main namespace." error while other pages that are not in the main namespace (such as Special:EditEventRegistration in this example) get a different error. I think this is probably fine since it does still display an error, but just calling it out here because it is inconsistent. Is this something we would want to fix? It not, we can move this to design sign off.

InT364802#9974571,@gonyeahialamwrote:

InT364802#9963020,@Daimonawrote:

InT364802#9962489,@vaughnwalterswrote:

@cmeloRight now, even if I haven't generated an invitation list, but I go to Special:InvitationList I see the messageYour list of editors to invite is being generated. Refresh the page in 5-10 minutes to view your invitation list.Is this expected for now? If so, then this ticket can be sent to design sign off.

Yup, that's the expected behaviour at this time.

@DaimonaBy 'at this time' you mean till the task for the copy change is done, right?

InT364804#9974535,@Daimonawrote:

InT364804#9974351,@gonyeahialamwrote:

InT364804#9974095,@Daimonawrote:

Also one more: should any of the accordions be open by default?

If it is possible to choose different behaviours, can the Highly recommended be open and the other one be closed by default?

Yes, it is possible. I'll do this.

InT364804#9974351,@gonyeahialamwrote:

InT364804#9974095,@Daimonawrote:

• Can we not hyperlink "invitation list criteria"? I think this will become redundant once we add a help link to this special page (which we also discussed yesterday). Speaking of which, should I create a task for that?

I wouldn't be redundant. It is good to have the help link on the special page but it is also best to surface the link where it is most likely to be needed. So when people see 'criteria' and they want to learn more they can immediately click on the link, it wouldn't be always obvious that they should click on the special page help link.

Also one more: should any of the accordions be open by default?

Thanks!

InT364804#9971301,@ifriedwrote:

Hey there,@Daimona&@gonyeahialam:I have updated the AC based on our discussions today; let me know what you think, and thank you both for all of the questions you raised & ideas you shared!

Actually, yeah, I've got a question. What should happen when there are no users to invite?

InT364804#9967500,@ifriedwrote:

@Daimona:Let me know if this looks good to go, or if you have any other open questions or concerns. Thanks!

@ifried@gonyeahialamJust a heads up that this task is currently marked as ready/in progress, so it'd be nice if we could finalize the AC. Also a couple more questions:

• I would also like to ask what the page title would be. Should it be "<invitation list name> invitation list" as in the specs? I wonder if that might be a bit confusing, depending on the name of the list. Maybe we could add a colon after the list name?

Given that a user hovers over the tooltip

InT367224#9963229,@ifriedwrote:

In that case,@Daimona&@MHorsey-WMF,what do you think about a 100 wiki limitation for specifying the wiki of the event? Do you have any concerns from a technical perspective?

InT369033#9962586,@ifriedwrote:

Hello,@Daimona&@gonyeahialam,I have updated the AC. I decided to include a different message for invalid ID, since I thought a message that is specific to this error would a) be more helpful to the user, and b) follow similar behavior found elsewhere (i.e., in Special:EventDetails). Let me know what you think and if you have any concerns. Thanks!

InT364802#9962489,@vaughnwalterswrote:

@cmeloRight now, even if I haven't generated an invitation list, but I go to Special:InvitationList I see the messageYour list of editors to invite is being generated. Refresh the page in 5-10 minutes to view your invitation list.Is this expected for now? If so, then this ticket can be sent to design sign off.

InT369033#9956785,@gonyeahialamwrote:

InT369033#9954714,@Daimonawrote:

Eh, on second thought, we also need a message for when an invalid ID is provided, i.e., something that is not a number. For comparison, on Special:EventDetails we use the following message:

Provide a valid event ID.

@ifried@gonyeahialam

Can't we treat it the same as an ID that does not exist

Eh, on second thought, we also need a message for when an invalid ID is provided, i.e., something that is not a number. For comparison, on Special:EventDetails we use the following message:

Not testable, hence resolving.

InT268652#9946711,@debtwrote:

Hi@Daimona- is this something you still want to publish on the tech blog?

InT366354#9950584,@Ladsgroupwrote:

I wish we could use linktarget ids instead but given their complexity and the fact that page title won't be repeated much I think it's fine for now. It's good to go.

InT366765#9951014,@gonyeahialamwrote:

InT366765#9950520,@Daimonawrote:

InT366765#9950264,@gonyeahialamwrote:

@DaimonaWhat do you mean by third parties

MediaWiki sites that are not hosted by the WMF (e.g., Fandom).

Are they going to be using our tool?

InT366765#9950264,@gonyeahialamwrote:

@DaimonaWhat do you mean by third parties

Discussed today at eng+design. A few ideas/thoughts:

• Maybe we should limit the number of wikis organizers can enter, at least for the MVP version. This would make it easier to display them.
• What to do with events that do not specify any wikis? And what about events that target all wikis (e.g., global campaigns)? For example, show a radio in the form like the following:

Is this event targeting specific wikis?
◯ No
◯ All wikis
◯ Specific wikis

InT362702#9948279,@dcaussewrote:

Seems like that recentlyhttps://packages.sury.org/php/dists/buster/is now returning a 403

InT368821#9948211,@matmarexwrote:

The problem being, that escaping might actually be preventing XSSs vulnerabilities somewhere. And I don't think we have a good way of knowing that. Auditing all callers seems quite hard.

This would only happen if someone used$status->getMessage()->text()/->plain(),or$status->getWikiText(),and output it as if it was HTML, right?