Page MenuHomePhabricator

MUL - Language fallback not applied to placeholders after editing terms
Closed, ResolvedPublic

Assigned To
None
Authored By
Manuel
Jan 30 2024, 6:16 PM
Referenced Files
Restricted File
Apr 11 2024, 11:33 AM
F41734362: image.png
Jan 31 2024, 10:47 AM
F41734355: image.png
Jan 31 2024, 10:47 AM
F41734350: image.png
Jan 31 2024, 10:47 AM
F41734341: image.png
Jan 31 2024, 10:47 AM

Description

Currently, after editors click on publish in the term box, they don't immediately see the changes they made in mul labels updated. Instead, they have to manually refresh the page in the browser to see the changes. We want to fix this before the release on Wikidata proper.

Old

Before:

image.png (513×935 px, 77 KB)

Writing "TEST EDIT" into the mul Label:

image.png (593×935 px, 96 KB)

After clicking on "publish":

image.png (528×935 px, 76 KB)
  • Edit is NOT reflected in the placeholders (page reload is still needed)

New

After clicking on "publish":

image.png (528×935 px, 71 KB)
  • Edit is reflected in the placeholders
  • (Note: the screenshot also shows the title/heading having updated, but that’s another task, T135871)

Notes

Acceptance criteria:

  • Placeholders consider a changed mul label right after click on publish (=no page reload needed)

Event Timeline

Manuel renamed this task from MUL - Show updates after click on publish to MUL - Show updates after changing the mul labels right after click on publish.Jan 31 2024, 10:47 AM
Manuel updated the task description. (Show Details)
Manuel renamed this task from MUL - Show updates after changing the mul labels right after click on publish to MUL - Show updates right after click on publish when changing a mul label .Jan 31 2024, 10:50 AM
Manuel updated the task description. (Show Details)
Manuel updated the task description. (Show Details)
Manuel renamed this task from MUL - Show updates right after click on publish when changing a mul label to MUL - Language fallback not applied to placeholders after editing terms.Jan 31 2024, 11:07 AM
Manuel updated the task description. (Show Details)

Change #1018945 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] termbox: Update label input placeholder after edit

https://gerrit.wikimedia.org/r/1018945

Change #1018945 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] termbox: Update label input placeholder after edit

https://gerrit.wikimedia.org/r/1018945

This is working for me on Beta but not on Test Wikidata

I need to refresh the page for the change to go through on Test
{F45859280}

Yeah - will need to wait for the next train deploy before this shows up on test. Some time Tuesday / Wednesday next week.

Arian_Bozorg claimed this task.

Looks good to me! Thank you :)