ManiphestT311916

"Add an image" structured edits add a blank line instead of an image
Closed, ResolvedPublic
Actions

Description

Hello,

it wasreportedby David V. at Czech Wikipedia that several edits tagged as "Add an image" edits actually do not add any image (instead, they only add a blank line).

This appears to affect all add an image edits made since 2022-06-23 (seeRecentChanges). The bug appears to affectarwiki,bnwiki,cswikiandeswikiat least. I did not check any other Growth projects. Considering the number of affected usersandprojects, this is very likely a bug.

Examples (one per wiki, more can be found in the RecentChanges links above):

Filling directly in sprint, as this seems to be a high-priority issue.

Details

Subject	Repo	Branch	Lines +/-
AddImage: Throw an error if File reference isn't found in new wikitext	mediawiki/extensions/GrowthExperiments	master	+125-20
AddImageArticleTarget: Update to new mediaClass/mediaTag format	mediawiki/extensions/GrowthExperiments	wmf/1.39.0-wmf.18	+2-1
AddImageArticleTarget: Update to new mediaClass/mediaTag format	mediawiki/extensions/GrowthExperiments	master	+2-1

Customize query in gerrit

Related Objects

Mentioned In: T311995: selenium: Add Link tests should verify that content is added to page
Mentioned Here: T311995: selenium: Add Link tests should verify that content is added to page
T273505: Merge mw:Image|mw:Audio|mw:Video into a single mw:File
rEVED0533f49fd574: Support the upcoming mw:File typeof

Event Timeline

Urbanecm_WMFcreated this task.Jul 2 2022, 2:10 PM

Restricted Applicationadded a subscriber:Aklapper.·View Herald TranscriptJul 2 2022, 2:10 PM

Urbanecm_WMFrenamed this task from"Add an image" structured edits made by Czech Wikipedia users do not add any imageto"Add an image" structured edits add a blank line instead of an image.Jul 2 2022, 2:11 PM

Urbanecm_WMFtriaged this task asHighpriority.

MdsShakilsubscribed.Jul 2 2022, 3:06 PM

It appears thatrEVED0533f49fd574: Support the upcoming mw:File typeofforT273505: Merge mw:Image|mw:Audio|mw:Video into a single mw:Filecaused this breakage. (According togit bisectanyway.) We had previously merged a patch toupdate some code comments for our patch,but that was before0533f49fd5741d145141d97f4dbf4979cd075287was merged, so no one noticed the breakage until now.

InT311916#8046297,@kostajhwrote:

It appears thatrEVED0533f49fd574: Support the upcoming mw:File typeofforT273505: Merge mw:Image|mw:Audio|mw:Video into a single mw:Filecaused this breakage. (According togit bisectanyway.) We had previously merged a patch toupdate some code comments for our patch,but that was before0533f49fd5741d145141d97f4dbf4979cd075287was merged, so no one noticed the breakage until now.

In the interim, I disabled the image-recommendation task type on all of our participating wikis, as the feature is completely broken and creates a maintenance burden and unpleasant experience for newcomers and experienced editors alike. For users in the image recommendation experiment, it means their task type filters are reset to an empty state. Assuming they interact with their filters, after we fix the bug and re-enable the task type, those users won't have image recommendation task type enabled any longer. cc@nettrom_WMFabout the experiment implications of that (sorry!).

kostajhadded a project:Regression.Jul 2 2022, 3:26 PM

Change 810467 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddImageArticleTarget: Update to new mediaClass/mediaTag format

https://gerrit.wikimedia.org/r/810467

gerritbotadded a project:Patch-For-Review.Jul 2 2022, 3:32 PM

Change 810467mergedby jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddImageArticleTarget: Update to new mediaClass/mediaTag format

https://gerrit.wikimedia.org/r/810467

Maintenance_botremoved a project:Patch-For-Review.Jul 2 2022, 6:30 PM

Change 810509 had a related patch set uploaded (by Urbanecm; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.18] AddImageArticleTarget: Update to new mediaClass/mediaTag format

https://gerrit.wikimedia.org/r/810509

gerritbotadded a project:Patch-For-Review.Jul 2 2022, 6:33 PM

Change 810485 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] [WIP] AddImage: Throw an error if mw:File isn't found in wikitext

https://gerrit.wikimedia.org/r/810485

KStoller-WMFassigned this task tokostajh.Jul 3 2022, 5:50 PM

KStoller-WMFsubscribed.

kostajhmentioned this inT311995: selenium: Add Link tests should verify that content is added to page.Jul 4 2022, 10:16 AM

Change 810509mergedby jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.18] AddImageArticleTarget: Update to new mediaClass/mediaTag format

https://gerrit.wikimedia.org/r/810509

Mentioned in SAL (#wikimedia-operations)[2022-07-04T11:50:03Z] <ladsgroup@deploy1002> Synchronized php-1.39.0-wmf.18/extensions/GrowthExperiments/modules/ext.growthExperiments.StructuredTask/addimage/AddImageArticleTarget.js: Backport: [[gerrit:810509|AddImageArticleTarget: Update to new mediaClass/mediaTag format (T311916)]] (duration: 03m 33s)

CBogenmoved this task fromTo DotoGrowth: Add an Imageon theImage-Suggestionsboard.Jul 7 2022, 6:36 PM

I think no more work is needed here (the WIP patch is covered byT311995). Please undo the move if I misunderstood.

ReleaseTaggerBotadded a project:MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 12:02 AM

ReleaseTaggerBotedited projects, addedMW-1.39-notes (1.39.0-wmf.18; 2022-06-27);removedMW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 1:01 AM

Etonkovidovaclosed this task asResolved.Jul 19 2022, 12:47 AM

Change 810485abandonedby Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@master] AddImage: Throw an error if File reference isn't found in new wikitext

Reason: