Page MenuHomePhabricator
Create Task
ManiphestT317821

Add a link to Recent changes made by mentees from the Mentor dashboard
Closed, ResolvedPublic
Actions

Assigned To
Urbanecm_WMF
Authored By
KStoller-WMF
Sep 14 2022, 10:01 PM
Tags
Referenced Files
F35719679: image.png
Nov 8 2022, 11:21 AM
F35717472: Screen Shot 2022-11-07 at 6.22.14 PM.png
Nov 8 2022, 2:54 AM
F35572849: Screen Shot 2022-10-14 at 8.47.59 AM.png
Oct 14 2022, 3:56 PM
F35565747: Screenshot 2022-10-13 at 10.41.38.png
Oct 13 2022, 9:45 AM
F35563439: Screen Shot 2022-10-11 at 12.09.16 PM.png
Oct 11 2022, 7:13 PM
F35560795: Screenshot 2022-10-10 at 12.39.37.png
Oct 10 2022, 11:43 AM
F35560740: Screenshot 2022-10-10 at 12.04.24.png
Oct 10 2022, 11:05 AM
F35560734: Screenshot 2022-10-10 at 12.01.47.png
Oct 10 2022, 11:05 AM
Subscribers
Aklapper
Etonkovidova
•KieranMcCann
kostajh
KStoller-WMF
RHo

Description

As a Mentor, when I view my Mentor dashboard, then I can quickly navigate to the Recent changes feed filtered to show only edits from my mentees

Description
Some Mentors don't realized they can easily filter the Recent Changes feed to view only edits from their Mentees. Let's consider adding an easy way to navigate from the Mentor dashboard to a filtered view of Recent Changes narrowed down bymentorship+all.

Hypotheses:

  • If we provide a path to this filtered view from the Mentor dashboard, then more Mentors will review their Mentee's edits
  • If we provide a path to this filtered view from the Mentor dashboard, and also provide more incentives to encourage Mentors send praise to newcomers, then more Mentors will thank newcomers for good edits.

Design:
Figma file(Design D. Link below table in distinct section with heading)

Screen Shot 2022-10-14 at 8.47.59 AM.png (982×878 px, 123 KB)

Copy:

Recent changes by your mentees
You can view the edits made by all your mentees by visiting this filtered view of Recent Changes.

"this filtered view of Recent Changes" should link the Recent Changes, filtered bymentorship+all.

Acceptance Criteria

Given I'm a Mentor,
When I am viewing my Mentor dashboard,
Then from my "Your mentees" module, I can navigate to Recent Changes made by my mentees

Details

SubjectRepoBranchLines +/-
MenteeOverview: Add a link to recent changes by menteesmediawiki/extensions/GrowthExperimentsmaster+84-1
Customize query in gerrit

Event Timeline

KStoller-WMFcreated this task.Sep 14 2022, 10:01 PM
Restricted Applicationadded a subscriber:Aklapper.·View Herald TranscriptSep 14 2022, 10:01 PM
KStoller-WMFadded a project:GrowthExperiments-MentorDashboard.Sep 14 2022, 10:02 PM
KStoller-WMFmoved this task fromInboxtoUpcoming Workon theGrowth-Teamboard.
Maintenance_botadded a project:GrowthExperiments-Mentorship.Sep 14 2022, 10:30 PM
KStoller-WMFmoved this task fromNew TaskstoNeeds Discussionon theGrowthExperiments-Mentorshipboard.Sep 28 2022, 5:33 PM
•KieranMcCannsubscribed.Oct 10 2022, 11:05 AM

@KStoller-WMFI think the simplest solution to this would be to add a line of copy at the bottom of the module with a link to the filtered recent changes page:

Screenshot 2022-10-10 at 12.01.47.png (1×1 px, 392 KB)

I looked at adding this line of copy within the text at the top but not sure if it might be overlooked in this position?:

Screenshot 2022-10-10 at 12.04.24.png (1×1 px, 395 KB)
kostajhsubscribed.Oct 10 2022, 11:13 AM
InT317821#8304456,@KieranMcCannwrote:

@KStoller-WMFI think the simplest solution to this would be to add a line of copy at the bottom of the module with a link to the filtered recent changes page:

Screenshot 2022-10-10 at 12.01.47.png (1×1 px, 392 KB)

I looked at adding this line of copy within the text at the top but not sure if it might be overlooked in this position?:

Screenshot 2022-10-10 at 12.04.24.png (1×1 px, 395 KB)

Maybe it could be a dedicated button next to the Filters button, with a tooltip containing the sentence from the mock?

•KieranMcCannadded a comment.Oct 10 2022, 11:43 AM

Thanks for the suggestion@kostajh.I mocked it up but it doesn’t feel right to me for a few of reasons:

  • the items in that space feel like they should directly relate to or affect the table below
  • I think it will be challenging to make the text in the button both clear and concise
  • I don’t think it should be a button as it is technically a link rather than an action

Screenshot 2022-10-10 at 12.39.37.png (1×1 px, 380 KB)
KStoller-WMFadded a comment.Oct 11 2022, 7:13 PM

Yeah, there isn't an obvious correct location for the link. I like the idea of less text, but I agree the button doesn't quite make sense there.

InT317821#8304456,@KieranMcCannwrote:

I think the simplest solution to this would be to add a line of copy at the bottom of the module with a link to the filtered recent changes page:

Screenshot 2022-10-10 at 12.01.47.png (1×1 px, 392 KB)

Agreed, this seems simple and logical.
My only suggestion is that we might want to consider differentiating that text slightly in some way. Perhaps in a similar way to how we separate "Claim mentee" in Settings. But I'm in no way attached to that idea, it just seems like "Recent changes by your mentees" is logically a subsection of "Your mentees", but it's also somewhat separate from the main table view, so it might be nice to visually separate it in some way. But feel free to disagree!

Screen Shot 2022-10-11 at 12.09.16 PM.png (890×1 px, 330 KB)
•KieranMcCannadded a comment.Oct 13 2022, 9:45 AM

My only suggestion is that we might want to consider differentiating that text slightly in some way. Perhaps in a similar way to how we separate "Claim mentee" in Settings. But I'm in no way attached to that idea, it just seems like "Recent changes by your mentees" is logically a subsection of "Your mentees", but it's also somewhat separate from the main table view, so it might be nice to visually separate it in some way. But feel free to disagree!

@KStoller-WMFYes I think that’s a good idea to distinguish it from the table a bit. Here’s a mock-up...

Screenshot 2022-10-13 at 10.41.38.png (1×1 px, 283 KB)
KStoller-WMFadded a subscriber:RHo.Oct 13 2022, 4:00 PM

Screenshot 2022-10-13 at 10.41.38.png (1×1 px, 283 KB)

Nice, I personally like having it separated like that.

@RHothis is the task I briefly mentioned when we met. Any thoughts on this design / plan?

RHoadded a comment.Oct 14 2022, 10:46 AM
InT317821#8314779,@KStoller-WMFwrote:

Screenshot 2022-10-13 at 10.41.38.png (1×1 px, 283 KB)

Nice, I personally like having it separated like that.

@RHothis is the task I briefly mentioned when we met. Any thoughts on this design / plan?

LGTM!

KStoller-WMFtriaged this task asMediumpriority.Oct 14 2022, 3:56 PM
KStoller-WMFupdated the task description.(Show Details)
KStoller-WMFmoved this task fromNeeds DiscussiontoPrioritizedon theGrowthExperiments-Mentorshipboard.
KStoller-WMFedited projects, addedGrowth-Team (Sprint 0 (Growth Team));removedGrowth-Team.
KStoller-WMFmoved this task fromIncomingtoReady for Developmenton theGrowth-Team (Sprint 0 (Growth Team))board.
Maintenance_botmoved this task fromPrioritizedtoIn Progresson theGrowthExperiments-Mentorshipboard.Oct 14 2022, 4:15 PM
Urbanecm_WMFclaimed this task.Oct 14 2022, 10:47 PM
Urbanecm_WMFmoved this task fromReady for DevelopmenttoIn Progresson theGrowth-Team (Sprint 0 (Growth Team))board.
gerritbotadded a comment.Oct 20 2022, 2:50 PM

Change 844992 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [WIP] MenteeOverview: Add a link to recent changes by mentees

https://gerrit.wikimedia.org/r/844992

gerritbotadded a project:Patch-For-Review.Oct 20 2022, 2:50 PM
Urbanecm_WMFchanged the task status fromOpentoIn Progress.Oct 22 2022, 6:52 PM
Urbanecm_WMFmoved this task fromIn ProgresstoCode Reviewon theGrowth-Team (Sprint 0 (Growth Team))board.
gerritbotadded a comment.Oct 25 2022, 10:16 AM

Change 844992mergedby jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MenteeOverview: Add a link to recent changes by mentees

https://gerrit.wikimedia.org/r/844992

Maintenance_botremoved a project:Patch-For-Review.Oct 25 2022, 10:30 AM
Urbanecm_WMFadded a comment.Oct 25 2022, 10:59 AM

@KStoller-WMFFYI, this will be deployed with the wmf.8 train (Thursday Nov 03 for Wikipedias).

ReleaseTaggerBotadded a project:MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 25 2022, 11:00 AM
Urbanecm_WMFchanged the task status fromIn ProgresstoOpen.Oct 25 2022, 11:01 AM
Urbanecm_WMFmoved this task fromCode ReviewtoQAon theGrowth-Team (Sprint 0 (Growth Team))board.
KStoller-WMFadded a comment.Oct 28 2022, 2:48 AM
InT317821#8341124,@Urbanecm_WMFwrote:

@KStoller-WMFFYI, this will be deployed with the wmf.8 train (Thursday Nov 03 for Wikipedias).

Thanks! I included this in theweekly Growth update.

Urbanecm_WMFmoved this task fromIn ProgresstoReady for QAon theGrowthExperiments-Mentorshipboard.Nov 7 2022, 8:51 AM
Etonkovidovaclosed this task asResolved.EditedNov 8 2022, 2:54 AM
Etonkovidovasubscribed.

Checked inwmf.8- the link is present on Special:MentorDashboard

Screen Shot 2022-11-07 at 6.22.14 PM.png (736×984 px, 104 KB)

@Urbanecm_WMF- just to double check: the link from Special:MentorDashboard will display the filter which includes the following filters

  • Human (not bot)
  • Not translations
  • Page edits
  • Page creations
  • Logged actions
  • New users
  • Your starred mentees
  • Your unstarred mentees

Basically, the two mentees-related filters are added to the initial default set of filters plus of the filter options a user did set on Special:Preferences#mw-prefsection-rc. It could be a little confusing for mentors to see that starred/unstarred mentees filters get append to the set of (original) default filters.

Urbanecm_WMFadded a comment.Nov 8 2022, 11:21 AM

Thanks@Etonkovidova,this sounds about right. Itshouldalso take in account user's personal defaults, if they used the "Set as default" button (see screenshot below). Sorry for not mentioning that in the acceptance criteria.

image.png (304×429 px, 13 KB)
Etonkovidovaadded a comment.Nov 8 2022, 5:55 PM
InT317821#8378998,@Urbanecm_WMFwrote:

Thanks@Etonkovidova,this sounds about right. Itshouldalso take in account user's personal defaults, if they used the "Set as default" button (see screenshot below). Sorry for not mentioning that in the acceptance criteria.

image.png (304×429 px, 13 KB)

Thx,@Urbanecm_WMF.I did test the case with the user-defined default filter. Such users' personal default filters won't be taken into account. Since it's relatively easy to come up with combinations of user-defined default filter and starred/unstarred mentees filters that might produce zero results or limiting the expected results. For example, if a user sets as their default filter "Bot + Likely bad faith", adding starred/unstarred mentees filters to that would significantly limit the info of mentees' activities

The description on Special:MentorDashboard - "Recent changes by your mentees. You can view the edits made by all your mentees by visiting this filtered view of Recent Changes." - states thatall editsby mentees will be shown.

To summarize the current implementation: clicking on the link on Special:MentorDashboard "filtered view of Recent Changes" will

  • add Starred/Unstarred mentees filters tothe initial (original) defaultset of filters on Special:RecentChanges, i.e.

Human (not bot)
No translations
Page edits
Page creations
Logged actions
New users

  • thatinitial (original) defaultwill include the options that were set by a user onSpecial:Preferencess#mw-prefsection-rc,which may reduce the overall number of mentees' edits being displayed
  • the personal user default filter on Special:RecentChanges won't be taken into account
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct.·Wikimedia Foundation·Privacy Policy·Code of Conduct·Terms of Use·Disclaimer·CC-BY-SA·GPL·Credits